Fix: Enable underscores in direct method invocations to match hyphens #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
added a commit
to zastrowm/docs
that referenced
this pull request
Jun 5, 2025
Documents the bugfix implemented in strands-agents/sdk-python#178 where underscores take the place of hyphens
This was referenced Jun 5, 2025
Enable direct method tool invocations of `example_tool` to match tools with the name of `example-tool`, which fixes strands-agents#139. In the case where no direct match is found but multiple tools would match, we throw an error to avoid ambiguous errors
d534ac6 to
dd14422
Compare
dbschmigelski
approved these changes
Jun 9, 2025
zastrowm
added a commit
to strands-agents/docs
that referenced
this pull request
Jun 9, 2025
* feat: Document invoking tools with hyphens Documents the bugfix implemented in strands-agents/sdk-python#178 where underscores take the place of hyphens --------- Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
zastrowm
added a commit
to zastrowm/sdk-python
that referenced
this pull request
Jun 9, 2025
Per follow-up to strands-agents#178, where we discussed preventing similar_tool and similar-tool from both being added to the tool registry, to avoid ambiguity in direct-method invocations
6 tasks
15 tasks
zastrowm
added a commit
to zastrowm/sdk-python
that referenced
this pull request
Jun 11, 2025
Per follow-up to strands-agents#178, where we discussed preventing similar_tool and similar-tool from both being added to the tool registry, to avoid ambiguity in direct-method invocations
zastrowm
added a commit
that referenced
this pull request
Jun 11, 2025
Per follow-up to #178, where we discussed preventing similar_tool and similar-tool from both being added to the tool registry, to avoid ambiguity in direct-method invocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable direct method tool invocations of
example_toolto match tools with the name ofexample-tool, which fixes #139. In the case where no direct match is found but multiple tools would match, we throw an error to avoid ambiguous errorsRelated Issues
#139
Documentation PR
strands-agents/docs#83
Type of Change
Testing
[How have you tested the change?]
hatch fmt --linterhatch fmt --formatterhatch test --allChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.