8000 chore: enhance error messaging when MCP tools are used without sessio… by dbschmigelski · Pull Request #175 · strands-agents/sdk-python · GitHub
[go: up one dir, main page]

Skip to content

chore: enhance error messaging when MCP tools are used without sessio… #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dbschmigelski
Copy link
Member
@dbschmigelski dbschmigelski commented Jun 4, 2025

Description

Enhanced error messaging when MCP tools are used outside of the client context manager. This change improves the developer experience by providing more descriptive error messages that guide users on proper usage.

Problem: When MCP tools are used outside of the client context manager (with mcp_client:), the error message "the client session is not running" does not provide clear guidance on how to resolve the issue.

Solution: Updated the error message to explicitly indicate that the MCP client must be used within the context manager, making it easier for developers to identify and fix the issue.

Related Issues

Partially addresses #96 - STDIO MCP tool not working

Documentation PR

N/A

Type of Change

  • Other (please describe): Improve error messaging to guide user.

Testing

Yes.

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dbschmigelski dbschmigelski requested a review from a team as a code owner June 4, 2025 12:05
zastrowm
zastrowm previously approved these changes Jun 4, 2025
Co-authored-by: Mackenzie Zastrow <3211021+zastrowm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0