8000 Fix: Preserve deeply nested schemas by lukehau · Pull Request #133 · strands-agents/sdk-python · GitHub
[go: up one dir, main page]
Skip to content

Fix: Preserve deeply nested schemas #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

Fix: Preserve deeply nested schemas #133

merged 2 commits into from
Jun 5, 2025

Conversation

lukehau
Copy link
Contributor
@lukehau lukehau commented May 28, 2025

Description

  • Modifying normalisation logic to recursively processes nested objects to preserve the complete schema structure
  • Adding tests for schema's with nested objects

Related Issues

#124

Type of Change

  • Bug fix

Testing

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Tested with own strands-agents implementation

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lukehau lukehau requested a review from a team as a code owner May 28, 2025 04:24
zastrowm
zastrowm reviewed May 28, 2025
View reviewed changes
@yonib05 yonib05 linked an issue May 28, 2025 that may be closed by this pull request
[BUG] Tool spec normalization #124
Closed
3 tasks
@lukehau lukehau requested a review from zastrowm May 29, 2025 00:50
@jer96 jer96 self-assigned this Jun 3, 2025
@jer96
Copy link
jer96 commented Jun 3, 2025 •
edited
Loading

hi @lukehau my sincerest apologies, i did not mean to overwrite the changes on your branch. i was attempting to clone, rebase and approve the changes and go ahead and merge them. if you would like, feel free to update the PR with you as the sole author and committer, else i'm more than happy to merge - the changes do indeed look good to me.

@lukehau
Copy link
Contributor Author
lukehau commented Jun 4, 2025

All good @jer96 - feel free to merge.

As long as I still get a phonetool award or something in the future 😉

zastrowm
zastrowm approved these changes Jun 5, 2025
View reviewed changes
@jer96 jer96 merged commit 8ffe24b into strands-agents:main Jun 5, 2025
10 checks passed
@fede-dash fede-dash mentioned this pull request Jun 10, 2025
Draft
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zastrowm zastrowm zastrowm approved these changes

@jer96 jer96 jer96 approved these changes

Assignees

@zastrowm zastrowm

@jer96 jer96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Tool spec normalization
3 participants
@lukehau @jer96 @zastrowm
0