8000 style(callback_handler): fix docstring for PrintingCallbackHandler.__call__ by awsarron · Pull Request #126 · strands-agents/sdk-python · GitHub
[go: up one dir, main page]
Skip to content

style(callback_handler): fix docstring for PrintingCallbackHandler.__call__ #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

style(callback_handler): fix docstring for PrintingCallbackHandler.__call__ #126

merged 1 commit into from
May 27, 2025

Conversation

awsarron
Copy link
Member
@awsarron awsarron commented May 27, 2025 •
edited
Loading

Description

fix docstring for PrintingCallbackHandler.__call__

resolves:

WARNING -  griffe: /Users/arron/.env/lib/python3.13/site-packages/strands/handlers/callback_handler.py:20: Parameter '-' does not appear in the function signature
WARNING -  griffe: /Users/arron/.env/lib/python3.13/site-packages/strands/handlers/callback_handler.py:21: Parameter '-' does not appear in the function signature
WARNING -  griffe: /Users/arron/.env/lib/python3.13/site-packages/strands/handlers/callback_handler.py:22: Parameter '-' does not appear in the function signature
WARNING -  griffe: /Users/arron/.env/lib/python3.13/site-packages/strands/handlers/callback_handler.py:23: Parameter '-' does not appear in the function signature

Type of Change

  • Documentation update

Testing

  • hatch fmt
  • hatch run test-lint
  • hatch test --all
  • Ran mkdocs serve -a 0.0.0.0:8000 in the strands-agents/docs repository and verified that the griffe warning disappeared

Checklist

  • I have read the CONTRIBUTING document
  • [-] I have added tests that prove my fix is effective or my feature works
  • [-] I have updated the documentation accordingly
  • [-] I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@awsarron awsarron requested a review from a team as a code owner May 27, 2025 16:47
@awsarron awsarron merged commit b04c4be into strands-agents:main May 27, 2025
20 checks passed
@awsarron awsarron deleted the fix-docstring-printingcallbackhandler branch May 27, 2025 17:13
@fede-dash fede-dash mentioned this pull request Jun 10, 2025
Draft
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zastrowm zastrowm zastrowm approved these changes

@Unshure Unshure Unshure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awsarron @zastrowm @Unshure
0