8000 feat: implement summarizing conversation manager by stefanoamorelli · Pull Request #112 · strands-agents/sdk-python · GitHub
[go: up one dir, main page]
Skip to content

feat: implement summarizing conversation manager #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

feat: implement summarizing conversation manager #112

merged 1 commit into from
Jun 10, 2025

Conversation

stefanoamorelli
Copy link
Contributor
@stefanoamorelli stefanoamorelli commented May 25, 2025 •
edited
Loading

Description

Tip

Follows conventional commits. Better reviewed commit-by-commit.

Introducing a new SummarizingConversationManager as an alternative to the existing sliding window approach. It optionally uses AI-powered summarization to retain the semantic context of older messages, rather than discarding them, while staying within model context limits.

Related Issues

Closes #90

Documentation PR

strands-agents/docs#63

Type of Change

  • New feature

Testing

  • hatch fmt --linter
  • hatch fmt --formatter
  • hatch test --all
  • Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stefanoamorelli stefanoamorelli requested a review from a team as a code owner May 25, 2025 15:40
@stefanoamorelli stefanoamorelli mentioned this pull request May 25, 2025
Open
6 tasks
@stefanoamorelli stefanoamorelli force-pushed the feat/summarizing-conversation-manager branch from 712e2ba to 3fa3bd7 Compare May 25, 2025 19:49
@stefanoamorelli stefanoamorelli mentioned this pull request May 26, 2025
Closed
Unshure
Unshure requested changes May 26, 2025
View reviewed changes
@stefanoamorelli stefanoamorelli force-pushed the feat/summarizing-conversation-manager branch 2 times, most recently from 02bb209 to f90af97 Compare May 27, 2025 18:33
@stefanoamorelli
Copy link
Contributor Author

@Unshure:

  • Using Agent (fallback to parent Agent if not provided) instead of Model;
  • Added ability to use a custom system prompt for the summarizer;
  • Removed the fallback to SlidingWindowConversationManager;
  • Improved the system prompt of the summarizer;
  • Kept multi-modal in the history;
  • Adjusted tests based on impl. and increased coverage; interactive-rebased to keep git history clean (not sure if you prefer to squash).

Let me know your feedback, I'll hold on the documentation updates until we have a final version (and before merging).

@stefanoamorelli stefanoamorelli requested a review from Unshure May 27, 2025 19:06
@Unshure Unshure self-assigned this May 29, 2025
@Unshure
Copy link
Member
Unshure commented May 29, 2025

Can you add an integration test for this implementation as well? We wand to make sure it passes end to end.

Unshure
Unshure requested changes May 29, 2025
View reviewed changes
@stefanoamorelli stefanoamorelli force-pushed the feat/summarizing-conversation-manager branch from f90af97 to 9431bf7 Compare June 1, 2025 16:11
@stefanoamorelli stefanoamorelli requested a review from Unshure June 1, 2025 16:13
@Unshure Unshure mentioned this pull request Jun 2, 2025
refactor: Update conversation manager interface #161
Merged
6 tasks
@stefanoamorelli stefanoamorelli force-pushed the feat/summarizing-conversation-manager branch 13 times, most recently from c0b84b2 to f1525c2 Compare June 3, 2025 21:46
Unshure
Unshure requested changes Jun 4, 2025
View reviewed changes
Copy link
Member
@Unshure Unshure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good, thank you for all the work here!

@stefanoamorelli stefanoamorelli force-pushed the feat/summarizing-conversation-manager branch 12 times, most recently from 565f7ef to ddb29f0 Compare June 5, 2025 21:06
@stefanoamorelli stefanoamorelli requested a review from Unshure June 5, 2025 21:12
@stefanoamorelli
Copy link
Contributor Author
stefanoamorelli commented Jun 5, 2025 •
edited
Loading

@Unshure thanks for all the feedback and really appreciate your thorough review 🙏 I've pushed the changes following your comments, let me know if I addressed everything.
(I let you resolve the pending threads)

Happy to contribute and help!

Unshure
Unshure requested changes Jun 6, 2025
View reviewed changes
Copy link
Member
@Unshure Unshure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! I was able to pull it locally and the integ tests ran much faster as well 🪄.

Few small things to clean up, and then this is good to merge!

prestomation
prestomation reviewed Jun 6, 2025
View reviewed changes
@stefanoamorelli stefanoamorelli force-pushed the feat/summarizing-conversation-manager branch 2 times, most recently from 9776766 to 4cd0ba8 Compare June 7, 2025 18:17
@stefanoamorelli stefanoamorelli force-pushed the feat/summarizing-conversation-manager branch from 4cd0ba8 to a11836e Compare June 7, 2025 18:21
@Unshure Unshure merged commit c28737c into strands-agents:main Jun 10, 2025
11 of 20 checks passed
@Unshure
Copy link
Member
Unshure commented Jun 10, 2025

Approved and merged! Really appreciate all of the work you did here @stefanoamorelli!

If you are feeling up for it, could you also update your docs pr here with the up to date information: strands-agents/docs#63

@stefanoamorelli
Copy link
Contributor Author

@Unshure sure, thank you! 🎉 Will update the documentation PR as well, consider it ready to review within tomorrow EOD 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unshure Unshure Unshure approved these changes

@prestomation prestomation Awaiting requested review from prestomation

Assignees

@Unshure Unshure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Compaction Conversation Manager
3 participants
@stefanoamorelli @Unshure @prestomation
0