8000 Add Wraith32 ESC Variant by geosmall · Pull Request #713 · stm32duino/Arduino_Core_STM32 · GitHub
[go: up one dir, main page]
Skip to content

Add Wraith32 ESC Variant #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 24, 2019
Merged

Add Wraith32 ESC Variant #713

merged 20 commits into from
Oct 24, 2019

Conversation

geosmall
Copy link
Contributor
@geosmall geosmall commented Oct 21, 2019 •
edited
Loading

Summary

Add Wraith32 V1 Electronic Speed Control Variant based on STM32F051K6.

https://www.readytoflyquads.com/35a-wraith32-v11-32bit-blheli-esc

Program with SWD, see pic below.

Program with SWD

Pads

fpistm
fpistm requested changes Oct 21, 2019
View reviewed changes
Copy link
Member
@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @geosmall
I would not add another menu.
Could you add it to Generic flight controllers.
I think also move the sparky one to this menu.

@geosmall
Copy link
Contributor Author
geosmall commented Oct 22, 2019 •
edited
Loading

Ok, I restructured Sparky and Wraith within menus.

Wraith is an electronic speed controller (aka ESC, for controlling a BLDC motor, as opposed FC that controls overall drone) with no USB provisions. I've relocated Sparky V1 under Generic flight controller menu. I've also created a new 'Electronic speed controllers' menu. I eventually plan to add ST's B-G431B-ESC1 speed controller here https://www.st.com/en/evaluation-tools/b-g431b-esc1.html

@geosmall geosmall requested a review from fpistm October 22, 2019 23:24
fpistm
fpistm requested changes Oct 23, 2019
View reviewed changes
@fpistm
Copy link
Member
fpistm commented Oct 23, 2019

Thanks for the refactoring @geosmall
Could you also rebase on top to solve conflict with boards.txt.

@fpistm fpistm added the new variant Add support of new bard label Oct 23, 2019
fpistm
fpistm requested changes Oct 23, 2019
View reviewed changes
Copy link
Member
@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM anyway a rebase on top of the master is required due to boards.txt conflict.

fpistm added 2 commits October 24, 2019 10:52
@fpistm
Merge pull request #605 from kbumsik/stm32mp1xx-package
8110ed4 
[New series] STM32MP1xx (just Cube package)
@fpistm
[MP1] Add HAL driver version
8225a2f 
Note: 1 extra commit included in this version which fix
TIM Break source definition

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm added this to the 1.8.0 milestone Oct 24, 2019
@geosmall geosmall requested a review from fpistm October 24, 2019 10:07
@geosmall
Copy link
Contributor Author
geosmall commented Oct 24, 2019 •
edited
Loading

Git rebase and merge are still new to me. I believe I may have screwed things up based on files changed.

Reading this now :) https://code.dblock.org/2015/08/31/getting-out-of-your-first-git-mess.html

@fpistm
Copy link
Member
fpistm commented Oct 24, 2019

Well, it seems you've pull the master directly on top of your commits.
First best practice is to use a branch not the master for a PR. Then it is easier to track and also to rebase on top of the master.
Kept master clean and sync with the original repo is also easier.
Anyway Github seems OK to suash and merge. Let see if it is OK else I will clean up.

@fpistm fpistm merged commit 726b406 into stm32duino:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
new variant Add support of new bard
Projects
None yet
Milestone
1.8.0🎄 🎅
Development

Successfully merging this pull request may close these issues.
5 participants
@geosmall @fpistm @kbumsik @jgillick @kent-williams
0