8000 Add Armed v1 board variant by ktand · Pull Request #364 · stm32duino/Arduino_Core_STM32 · GitHub
[go: up one dir, main page]
Skip to content

Add Armed v1 board variant #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2018
Merged

Add Armed v1 board variant #364

merged 2 commits into from
Nov 14, 2018

Conversation

ktand
Copy link
Contributor
@ktand ktand commented Oct 31, 2018

Armed is a 3D printer controller based on STM32F407 designed to run Marlin.

fpistm
fpistm reviewed Nov 1, 2018
View reviewed changes
@fpistm fpistm added the new variant Add support of new bard label Nov 1, 2018
@fpistm
Copy link
Member
fpistm commented Nov 1, 2018

I think it should also be nice to not add a new section for this board and follow @hasenbanck recommendation in #361:

I took the liberty to rename the menu section "RemRam series" to "3D printer boards" to not clutter the core more than necessary (as suggested in #347).

@hasenbanck
Copy link
Contributor
hasenbanck commented Nov 1, 2018 •
edited
Loading

I think it should also be nice to not add a new section for this board and follow @hasenbanck recommendation in #361:

I took the liberty to rename the menu section "RemRam series" to "3D printer boards" to not clutter the core more than necessary (as suggested in #347).

So

# Armed boards
Armed.name=Armed Series

would become

# 3D printer boards
3dprinter.name=3D printer boards

And then you would need to change Armed and RemRam into the new section "3dprinter".

I would then rebase my changes again and we wouldn't clutter the the main section more then we need.

@hasenbanck
Copy link
Contributor

Did you consider setting #define PWM_FREQUENCY 20000 // >= 20 Khz => inaudible noise for fans? I personally find low running FAN noise to be highly disturbing.

@ktand
Copy link
Contributor Author
ktand commented Nov 1, 2018 via email

@ktand
Copy link
Contributor Author
ktand commented Nov 1, 2018

Would sharing a "3d printer" section require all boards in that section to use the save USB vid/pid?

3dprinter.build.vid=0x0483
3dprinter.build.pid=0x5711
3dprinter.vid.0=0x0483
3dprinter.pid.0=0x5711

@fpistm
Copy link
Member
fpistm commented Nov 1, 2018

USB will be part of 1.5 based on @hasenbanck
About pid/vid I think it could be defined per variant if needed.
I think also we could in a first step do a separate PR to rename the RemRam series to 3D printer boards to avoid any conflicts issues with PR.

@ktand
Copy link
Contributor Author
ktand commented Nov 1, 2018

USB will be part of 1.5 based on @hasenbanck
About pid/vid I think it could be defined per variant if needed.
I think also we could in a first step do a separate PR to rename the RemRam series to 3D printer boards to avoid any conflicts issues with PR.

Ok. @hasenbanck , do you want med to submit the PR regarding the rename or will you do it?

@hasenbanck
Copy link
Contributor

@ktand I'm at work and would only have time this evening. If you are faster, then please do it yourself.

@ktand
Copy link
Contributor Author
ktand commented Nov 1, 2018

@ktand I'm at work and would only have time this evening. If you are faster, then please do it yourself.

Same here.

@hasenbanck
Copy link
Contributor

Found some time in the break. Here we go: #365

@ktand
Copy link
Contributor Author
ktand commented Nov 1, 2018

Found some time in the break. Here we go: #365

Is there any way I can base my PR on your PR? Or do I have to wait for your PR to be merged before I can adjust mine?

@hasenbanck
Copy link
Contributor

I would wait for the merge of the other PR and then do a rebase of this PR.

@fpistm
Copy link
Member
fpistm commented Nov 2, 2018

#365 merged.

@ktand
Copy link
Contributor Author
ktand commented Nov 2, 2018

I have updated my PR as suggested.

@ktand
Copy link
Contributor Author
ktand commented Nov 4, 2018

Tweaked SPI pin definition. Ready to be merged.

@ktand ktand force-pushed the armed_board_variant branch from 7d25e1b to ad65d9a Compare November 4, 2018 20:41
@fpistm fpistm mentioned this pull request Nov 14, 2018
Merged
@fpistm @ktand
PR 364 Review (#1)
814d669 
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member
fpistm commented Nov 14, 2018

Thanks @ktand
Please, could you share a link on a description of this board?
Thanks in advance.

fpistm
fpistm approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member
@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PeripheralPins.c is not the last version but this is not an issue if there is no ETH on this board

@fpistm fpistm added this to the 1.5.0 milestone Nov 14, 2018
@ktand
Copy link
Contributor Author
ktand commented Nov 14, 2018

@fpistm There is no ethernet on this board, but I can update the file to the latest version if you like.

@fpistm
Copy link
Member
fpistm commented Nov 14, 2018

@ktand No, if no ethernet that's good.
Just this request, please ;)

Please, could you share a link on a description of this board?
Thanks in advance.

@ktand
Copy link
Contributor Author
ktand commented Nov 14, 2018

@fpistm Sorry for the delay, cleaned up project and pushed to Github. Here is the link: Armed on Github

@hasenbanck
Copy link
Contributor

I approve the usage of good fuses! Nice board design!

@fpistm fpistm merged commit 703fdb8 into stm32duino:master Nov 14, 2018
@ktand ktand deleted the armed_board_variant branch November 14, 2018 20:31
benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull request Apr 10, 2019
@fpistm
Merge pull request stm32duino#364 from ktand/armed_board_variant
c7524a0 
Add Armed v1 board variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees

@ktand ktand

Labels
new variant Add support of new bard
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ktand @fpistm @hasenbanck
0