Create Destructor for Wire Class. #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This destructor allows reassigning either hardware peripheral to the default Wire() objects. sequence: Wire.~TwoWire(); Wire = TwoWire(peripherial); // peripheral is either 0 or 1 Wire.begin(sda,scl); // sda, scl are the pins to use, when using peripheral 1, YOU MUST specifiy the pins, there ARE NO DEFAULT VALUES for peripheral 1.
These changes allow both i2c peripherals to be use, if a TwoWire() object is destroyed, the associated peripheral is reset and powered down.
This change will not reset the SCL, SDA and Frequency values to their default value if `Wire.begin()` is call without any parameters. Arduino libraries that use `Wire()` usually have a call to `Wire.begin()` inside their initialization call. Without this change, any custom pin assignments are lost whenever `Wire.begin()` is called.
Changed how default parameters are interpreted. Now calling `Wire.begin()` without parameters will reuse the current values instead of resetting them to the default values. This change was prompted when it was found than custom pin assignments were being lost. The standard Arduino library practice is to issue a `Wire.begin()` call inside each library that uses `Wire()`. If a custom pin assignment was used, when these libraries were init'd, they caused a failure when they re-assigned the SDA and SCL pins. Changing Frequency back to 100khz was not a fatal problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This destructor allows reassigning either hardware peripheral to the default Wire() object.
sequence: