feat: add Wald distribution PDF #9324
Open
+1,491
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
reviewed
Dec 23, 2025
Comment on lines
52
to
63
| if ( | ||
| isnan( mu ) || | ||
| isnan( lambda ) | ||
| ) { | ||
| return constantFunction( NaN ); | ||
| } | ||
| if ( mu <= 0.0 ) { | ||
| return constantFunction( NaN ); | ||
| } | ||
| if ( lambda < 0.0 ) { | ||
| return constantFunction( NaN ); | ||
| } |
Member
There was a problem hiding this comment.
You can go ahead and consolidate these into a single if condition, given that all result in constantFunction( NaN ).
kgryte
reviewed
Dec 23, 2025
Comment on lines
97
to
109
| if ( | ||
| isnan( x ) || | ||
| isnan( mu ) || | ||
| isnan( lambda ) | ||
| ) { | ||
| return NaN; | ||
| } | ||
| if ( mu <= 0.0 ) { | ||
| return NaN; | ||
| } | ||
| if ( lambda < 0.0 ) { | ||
| return NaN; | ||
| } |
Member
There was a problem hiding this comment.
Same comment about collapsing the if conditions into one.
kgryte
reviewed
Dec 23, 2025
Comment on lines
42
to
54
| if ( | ||
| stdlib_base_is_nan( x ) || | ||
| stdlib_base_is_nan( mu ) || | ||
| stdlib_base_is_nan( lambda ) | ||
| ) { | ||
| return 0.0/0.0; // NaN | ||
| } | ||
| if ( mu <= 0.0 ) { | ||
| return 0.0/0.0; // NaN | ||
| } | ||
| if ( lambda < 0.0 ) { | ||
| return 0.0/0.0; // NaN | ||
| } |
kgryte
reviewed
Dec 23, 2025
Member
There was a problem hiding this comment.
Overall, this is looking good thus far!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #209
Description
This pull request:
Tests, docs, examples and benchmark is yet to added, pending approval of the core implementation.
Related Issues
This pull request has the following related issues:
Questions
No.
Other
I have used this Wiki page as a reference.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers