chore: fix JavaScript lint errors (issue #70 8000 19) #7020
Conversation
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
1 similar comment
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
| @@ -108,13 +108,11 @@ function Marks( options ) { | |||
| * @private | |||
| */ | |||
| function onRender() { | |||
| var args; | |||
| var args = ['render']; | |||
There was a problem hiding this comment.
| var args = ['render']; | |
| var args; |
| for ( i = 0; i < arguments.length; i++ ) { | ||
| args[ i+1 ] = arguments[ i ]; | ||
| args.push(arguments[i]); |
There was a problem hiding this comment.
| args.push(arguments[i]); | |
| args.push( arguments[ i ] ); |
| var i; | ||
| debug( 'Received a render event. Re-emitting...' ); | ||
| args = new Array( arguments.length+1 ); | ||
| args[ 0 ] = 'render'; | ||
| for ( i = 0; i < arguments.length; i++ ) { |
There was a problem hiding this comment.
| for ( i = 0; i < arguments.length; i++ ) { | |
| args = []; | |
| args[ 0 ] = 'render'; | |
| for ( i = 0; i < arguments.length; i++ ) { | 8000
There was a problem hiding this comment.
I think this should work
Signed-off-by: Uday Kakade <141299403+udaykakade25@users.noreply.github.com>
Resolves #7019.
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers