8000 Glm inverse deriv2 by gmcmacran · Pull Request #9456 · statsmodels/statsmodels · GitHub
[go: up one dir, main page]

Skip to content

Glm inverse deriv2 #9456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

gmcmacran
Copy link
Contributor
@gmcmacran gmcmacran commented Dec 15, 2024

Don't merge. Kicking off tests and documentation CI/CD.

This PR adds the second derivative of the inverse link function for the log, logit, and cloglog links.

@pep8speaks
Copy link
pep8speaks commented Dec 15, 2024

Hello @gmcmacran! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-15 00:28:07 UTC

@gmcmacran gmcmacran marked this pull request as draft December 15, 2024 00:19
return t*t_2


class logit(Logit):

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'logit' is unnecessary as it is
redefined
before this value is used.
@josef-pkt
Copy link
Member

needs checking whether this is a useful extension.
More explicit derivatives is better, but it might be covered already by some methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0