8000 [5.x] Allow statamic URLs to use fragments or query strings by miicah · Pull Request #13085 · statamic/cms · GitHub
[go: up one dir, main page]
Skip to content

[5.x] Allow statamic URLs to use fragments or query strings #13085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 2 commits into from
Nov 18, 2025
Merged

[5.x] Allow statamic URLs to use fragments or query strings #13085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cde153b
Allow statamic URLs to use fragments/querystrings
miicah Nov 18, 2025
d8f8084
add tests
jasonvarga Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Fieldtypes/Concerns/ResolvesStatamicUrls.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ trait ResolvesStatamicUrls
*/
protected function resolveStatamicUrls(string $content)
{
return preg_replace_callback('/([("])statamic:\/\/([^()"]*)([)"])/im', function ($matches) {
return preg_replace_callback('/([("])statamic:\/\/([^()"?#]*)([^()"]*)([)"])/im', function ($matches) {
$data = Data::find($matches[2]);
$url = $data ? $data->url() : '';
$url = $data ? $data->url().$matches[3] : '';

return $matches[1].$url.$matches[3];
return $matches[1].$url.$matches[4];
}, $content);
}
}
136 changes: 136 additions & 0 deletions tests/Fieldtypes/Concerns/ResolvesStatamicUrlsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,136 @@
<?php

namespace Tests\Fieldtypes\Concerns;

use Mockery;
use PHPUnit\Framework\Attributes\Test;
use Statamic\Facades\Data as DataFacade;
use Statamic\Fieldtypes\Concerns\ResolvesStatamicUrls;
use Tests\TestCase;

class ResolvesStatamicUrlsTest extends TestCase
{
private $testClass;

public function setUp(): void
{
parent::setUp();

$this->testClass = new class
{
use ResolvesStatamicUrls;

public function resolve(string $content)
{
return $this->resolveStatamicUrls($content);
}
};
}

#[Test]
public function it_calls_data_find_with_correct_id()
{
$data = Mockery::mock();
$data->shouldReceive('url')->andReturn('/some/url');

DataFacade::shouldReceive('find')
->once()
->with('foo::bar/baz.ext')
->andReturn($data);

$content = '[link](statamic://foo::bar/baz.ext)';
$result = $this->testClass->resolve($content);

$this->assertEquals('[link](/some/url)', $result);
}

#[Test]
public function it_handles_non_existent_data()
{
DataFacade::shouldReceive('find')
->once()
->with('non-existent')
->andReturn(null);

$content = '[link](statamic://non-existent)';
$result = $this->testClass->resolve($content);

$this->assertEquals('[link]()', $result);
}

#[Test]
public function it_handles_multiple_urls()
{
$data1 = Mockery::mock();
$data1->shouldReceive('url')->andReturn('/url-1');

$data2 = Mockery::mock();
$data2->shouldReceive('url')->andReturn('/url-2');

DataFacade::shouldReceive('find')
->once()
->with('id-1')
->andReturn($data1);

DataFacade::shouldReceive('find')
->once()
->with('id-2')
->andReturn($data2);

$content = '[link1](statamic://id-1) and <img src="statamic://id-2" />';
$result = $this->testClass->resolve($content);

$this->assertEquals('[link1](/url-1) and <img src="/url-2" />', $result);
}

#[Test]
public function it_maintains_hash_fragments()
{
$data = Mockery::mock();
$data->shouldReceive('url')->andReturn('/some/page');

DataFacade::shouldReceive('find')
->once()
->with('entry::123')
->andReturn($data);

$content = '[link](statamic://entry::123#section)';
$result = $this->testClass->resolve($content);

$this->assertEquals('[link](/some/page#section)', $result);
}

#[Test]
public function it_maintains_query_strings()
{
$data = Mockery::mock();
$data->shouldReceive('url')->andReturn('/some/page');

DataFacade::shouldReceive('find')
->once()
->with('entry::123')
->andReturn($data);

$content = '[link](statamic://entry::123?foo=bar)';
$result = $this->testClass->resolve($content);

$this->assertEquals('[link](/some/page?foo=bar)', $result);
}

#[Test]
public function it_maintains_query_strings_and_hash_fragments()
{
$data = Mockery::mock();
$data->shouldReceive('url')->andReturn('/some/page');

DataFacade::shouldReceive('find')
->once()
->with('entry::123')
->andReturn($data);

$content = '[link](statamic://entry::123?foo=bar#section)';
$result = $this->testClass->resolve($content);

$this->assertEquals('[link](/some/page?foo=bar#section)', $result);
}
}
0