8000 Add parameters to Client.search by TomAugspurger · Pull Request #283 · stac-utils/pystac-client · GitHub
[go: up one dir, main page]
Skip to content

Add parameters to Client.search #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2022
Merged

Add parameters to Client.search #283

merged 5 commits into from
Aug 2, 2022

Conversation

TomAugspurger
Copy link
Collaborator

Closes #282

@codecov-commenter
Copy link

Codecov Report

Merging #283 (9430e2a) into main (e6f30a6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files          10       10           
  Lines         717      717           
=======================================
  Hits          599      599           
  Misses        118      118
Impacted Files Coverage Δ
pystac_client/cli.py 60.31% <100.00%> (ø)
pystac_client/client.py 81.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f30a6...9430e2a. Read the comment docs.

gadomski
gadomski requested changes Aug 1, 2022
View reviewed changes
Copy link
Member
@gadomski gadomski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment change requested. Otherwise I'm 👍🏽; this helpfully exposes how complex ItemSearch.__init__ is, and encourages future simplification of the signature (e.g. we could probably push some of those arguments down to the retrieval functions).

@gadomski gadomski self-requested a review August 2, 2022 15:46
@gadomski gadomski merged commit 70ad84d into stac-utils:main Aug 2, 2022
@gadomski gadomski modified the milestones: 0.4.1, 0.5.0 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Use named arguments instead of **kwargs for Client.search()
3 participants
@TomAugspurger @codecov-commenter @gadomski
0