8000
  • Use CollectionAssert in ListDirectory tests by Rob-Hague · Pull Request #1166 · sshnet/SSH.NET · GitHub
    [go: up one dir, main page]
    Skip to content

    Use CollectionAssert in ListDirectory tests#1166

    Merged
    WojciechNagorski merged 4 commits intosshnet:developfrom
    Rob-Hague:collectionassert
    Nov 13, 2023
    Merged

    Use CollectionAssert in ListDirectory tests#1166
    WojciechNagorski merged 4 commits intosshnet:developfrom
    Rob-Hague:collectionassert

    Conversation

    @Rob-Hague
    Copy link
    Collaborator
    @Rob-Hague Rob-Hague commented Aug 30, 2023

    These tests were failing for me because the files were coming in in a different order

    Plus, CollectionAssert.AreEquivalent gives a nice failure message

    @WojciechNagorski
    Copy link
    Collaborator
    WojciechNagorski commented Aug 31, 2023

    Can you tell me in what order you got the results?
    I don't have full knowledge about the project yet, but perhaps th 8000 e problem is not checking, but a random order.

    @Rob-Hague
    Copy link
    Collaborator Author
    Rob-Hague commented Aug 31, 2023 
     Create_directory_with_contents_and_list_it
   Source: SftpClientTests.cs line 21
   Duration: 172 ms

  Message: 
Assert.AreEqual failed. Expected:</home/sshnet/sshnet-test/. False True
/home/sshnet/sshnet-test/.. False True
/home/sshnet/sshnet-test/test-file.txt True False
>. Actual:</home/sshnet/sshnet-test/test-file.txt True False
/home/sshnet/sshnet-test/. False True
/home/sshnet/sshnet-test/.. False True
>.

    Same for Create_directory_with_contents_and_list_it_async

    I have not looked at the implementation, but I would not expect it to do any sorting - the user can sort the files how they like.

    @WojciechNagorski
    Copy link
    Collaborator
    WojciechNagorski commented Aug 31, 2023

    It needs to be checked. I don't know if it shouldn't be deterministic.

    @Rob-Hague
    Copy link
    Collaborator Author
    Rob-Hague commented Sep 8, 2023

    So the directory listing functionality is the sending of a SSH_FXP_READDIR packet. I do not see anything relating to sort order in the RFC and the library implementation is reading out the filenames as they are returned (into an array, and then a list).

    SSH.NET/src/Renci.SshNet/SftpClient.cs

    Line 2276 in 9f1699b

    private IEnumerable<ISftpFile> InternalListDirectory(string path, Action<int> listCallback)

    SSH.NET/src/Renci.SshNet/Sftp/SftpSession.cs

    Line 1196 in 9f1699b

    public KeyValuePair<string, SftpFileAttributes>[] RequestReadDir(byte[] handle)

    SSH.NET/src/Renci.SshNet/Sftp/Responses/SftpNameResponse.cs

    Lines 27 to 44 in 9f1699b

    protected override void LoadData()
    {
    base.LoadData();
    Count = ReadUInt32();
    Files = new KeyValuePair<string, SftpFileAttributes>[Count];
    for (var i = 0; i < Count; i++)
    {
    var fileName = ReadString(Encoding);
    if (SupportsLongName(ProtocolVersion))
    {
    _ = ReadString(Encoding); // skip longname
    }
    Files[i] = new KeyValuePair<string, SftpFileAttributes>(fileName, ReadAttributes());
    }
    }

    It looks fine to me.

    @Rob-Hague Rob-Hague mentioned this pull request Sep 23, 2023
    Merged
    @Rob-Hague
    Copy link
    Collaborator Author
    Rob-Hague commented Oct 21, 2023

    Also seen in #1220

      Failed Create_directory_with_contents_and_list_it [128 ms]
  Error Message:
   Assert.AreEqual failed. Expected:</home/sshnet/sshnet-test/. False True
/home/sshnet/sshnet-test/.. False True
/home/sshnet/sshnet-test/test-file.txt True False
>. Actual:</home/sshnet/sshnet-test/.. False True
/home/sshnet/sshnet-test/test-file.txt True False
/home/sshnet/sshnet-test/. False True
>. 
  Stack Trace:
     at Renci.SshNet.IntegrationTests.SftpClientTests.Create_directory_with_contents_and_list_it() in /home/appveyor/projects/ssh-net/test/Renci.SshNet.IntegrationTests/SftpClientTests.cs:line 48
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

    drieseng
    drieseng requested changes Oct 30, 2023
    View reviewed changes
    @WojciechNagorski
    Copy link
    Collaborator
    WojciechNagorski commented Nov 13, 2023

    It is strange, but I've just got the same error ;)
    image

    @WojciechNagorski WojciechNagorski merged commit 823bc1b into sshnet:develop Nov 13, 2023
    @Rob-Hague Rob-Hague deleted the collectionassert branch November 13, 2023 07:31
    @WojciechNagorski WojciechNagorski added this to the 2023.0.1 milestone Nov 16, 2023
    @WojciechNagorski WojciechNagorski mentioned this pull request Dec 29, 2023
    Closed
    @WojciechNagorski
    Copy link
    Collaborator
    WojciechNagorski commented Dec 29, 2023

    The 2023.0.1 version has been released to Nuget: https://www.nuget.org/packages/SSH.NET/2023.0.1

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @drieseng drieseng drieseng requested changes

    @WojciechNagorski WojciechNagorski WojciechNagorski approved these changes

    Assignees

    No one assigned

    Labels

    None yet

    Projects

    None yet

    Milestone

    2023.0.1

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @Rob-Hague @WojciechNagorski @drieseng
    0