8000 Event bus by mvrhov · Pull Request #4 · sroze/symfony · GitHub
[go: up one dir, main page]
Skip to content

Event bus #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: add-message-component
Choose a base branch
from
Open

Event bus #4

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f79533e
Create the Message component
sroze Sep 30, 2017
099b423
Rename consumers to receivers and producers to senders. And a lot of …
sroze Dec 1, 2017
29a15e5
Add return to dispatch method and no need for handles parameter. We c…
mvrhov Dec 23, 2017
dd0d640
Rename Producer -> Sender in the FrameworkBundle as well
sroze Dec 24, 2017
ac80529
Do not pass anything if the message_bus service do not exists
sroze Dec 24, 2017
923324b
service class typo fix.
mvrhov Dec 25, 2017
af34b5c
Various valid changes based on reviews
sroze Dec 25, 2017
8c3c12e
Mention tags with the README
sroze Dec 25, 2017
697b722
The message bus is accessible via its interface and within the contro…
sroze Dec 25, 2017
383f5aa
Logging middleware containers the message class and uses the `message…
sroze Oct 6, 2017
7549ea5
Add messages in the profiler
sroze Oct 7, 2017
ee806ad
Message's collector is within the same XML file, not in `collectors`
sroze Dec 25, 2017
3847968
Handlers should be lazy loaded
mvrhov Dec 25, 2017
7e1d7b5
Fix multiple typos from Javier's review
sroze Dec 27, 2017
93fe7cf
Rename `MessageHandlerCollection` to `ChainHandler`
sroze Dec 27, 2017
36a170a
Added EventBus
mvrhov Dec 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename Producer -> Sender in the FrameworkBundle as well
  • Loading branch information
@sroze
sroze committed Dec 24, 2017
commit dd0d640d44bbeb5434edf4bf2d7376d6d479825e
4 changes: 2 additions & 2 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,11 +911,11 @@ private function addMessageSection(ArrayNodeDefinition $rootNode)
->beforeNormalization()
->ifString()
->then(function ($v) {
return array('producers' => array($v));
return array('senders' => array($v));
})
->end()
->children()
->arrayNode('producers')
->arrayNode('senders')
->requiresAtLeastOneElement()
->prototype('scalar')->end()
->end()
Expand Down
8 changes: 4 additions & 4 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,14 +1367,14 @@ private function registerMessageConfiguration(array $config, ContainerBuilder $c
{
$loader->load('message.xml');

$messageToProducerMapping = array();
$messageToSenderMapping = array();
foreach ($config['routing'] as $message => $messageConfiguration) {
$messageToProducerMapping[$message] = array_map(function (string $serviceName) {
$messageToSenderMapping[$message] = array_map(function (string $serviceName) {
return new Reference($serviceName);
}, $messageConfiguration['producers']);
}, $messageConfiguration['senders']);
}

$container->getDefinition('message.asynchronous.routing.producer_for_message_resolver')->setArgument(0, $messageToProducerMapping);
$container->getDefinition('message.asynchronous.routing.sender_locator')->setArgument(0, $messageToSenderMapping);
}

private function registerCacheConfiguration(array $config, ContainerBuilder $container)
Expand Down
6 changes: 3 additions & 3 deletions src/Symfony/Bundle/FrameworkBundle/Resources/config/message.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
</service>

<!-- Asynchronous -->
<service id="message.asynchronous.routing.producer_for_message_resolver" class="Symfony\Component\Message\Asynchronous\Routing\SenderLocator">
<argument type="collection" /> <!-- Message to producer mapping -->
<service id="message.asynchronous.routing.sender_locator" class="Symfony\Component\Message\Asynchronous\Routing\SenderLocator">
<argument type="collection" /> <!-- Message to sender mapping -->
</service>
<service id="message.asynchronous.middleware.send_message_to_producer" class="Symfony\Component\Message\Asynchronous\Middleware\SendMessageToProducersMiddleware">
<argument type="service" id="message.asynchronous.routing.producer_for_message_resolver" />
<argument type="service" id="message.asynchronous.routing.sender_locator" />

<tag name="message_middleware" priority="-5" />
</service>
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Message/DependencyInjection/MessagePass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ private function findHandlers(ContainerBuilder $container): array
}

$parameters = $method->getParameters();
if (count($parameters) !== 1) {
if (1 !== count($parameters)) {
throw new RuntimeException(sprintf('`__invoke` function of service "%s" must have exactly one parameter', $serviceId));
}

Expand Down
0