bug symfony#27197 [Messenger] Fix AMQP Transport factory & TransportFactoryInterface (ogizanagi)

sroze · sroze · commit ef2c091787b6 · 2018-05-08T16:21:30.000+01:00
This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Fix AMQP Transport factory & TransportFactoryInterface | Q | A | ------------- | --- | Branch? | 4.1  | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | symfony#27164  | License | MIT | Doc PR | N/A Seems like we did review a bit fast here 😅 Commits ------- 98967cd [Messenger] Fix AMQP Transport factory & TransportFactoryInterface
diff --git a/src/Symfony/Component/Messenger/Transport/AmqpExt/AmqpTransportFactory.php b/src/Symfony/Component/Messenger/Transport/AmqpExt/AmqpTransportFactory.php
@@ -34,7 +34,7 @@ public function __construct(EncoderInterface $encoder, DecoderInterface $decoder
 
     public function createTransport(string $dsn, array $options): TransportInterface
     {
-        return new AmqpTransport($this->encoder, $this->decoder, $dsn, $options, $thid->debug);
+        return new AmqpTransport($this->encoder, $this->decoder, $dsn, $options, $this->debug);
     }
 
     public function supports(string $dsn, array $options): bool
diff --git a/src/Symfony/Component/Messenger/Transport/TransportFactoryInterface.php b/src/Symfony/Component/Messenger/Transport/TransportFactoryInterface.php
@@ -20,9 +20,7 @@
  */
 interface TransportFactoryInterface
 {
-    public function createReceiver(string $dsn, array $options): ReceiverInterface;
-
-    public function createSender(string $dsn, array $options): SenderInterface;
+    public function createTransport(string $dsn, array $options): TransportInterface;
 
     public function supports(string $dsn, array $options): bool;
 }

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function __construct(EncoderInterface $encoder, DecoderInterface $decoder`
`34`	`34`
`35`	`35`	`public function createTransport(string $dsn, array $options): TransportInterface`
`36`	`36`	`{`
`37`		`- return new AmqpTransport($this->encoder, $this->decoder, $dsn, $options, $thid->debug);`
	`37`	`+ return new AmqpTransport($this->encoder, $this->decoder, $dsn, $options, $this->debug);`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`public function supports(string $dsn, array $options): bool`
Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,7 @@`
`20`	`20`	`*/`
`21`	`21`	`interface TransportFactoryInterface`
`22`	`22`	`{`
`23`		`- public function createReceiver(string $dsn, array $options): ReceiverInterface;`
`24`		`-`
`25`		`- public function createSender(string $dsn, array $options): SenderInterface;`
	`23`	`+ public function createTransport(string $dsn, array $options): TransportInterface;`
`26`	`24`
`27`	`25`	`public function supports(string $dsn, array $options): bool;`
`28`	`26`	`}`