minor symfony#26465 Default deleteFileAfterSend() to true (nowendwell)

fabpot · fabpot · commit 7ff71b548b50 · 2018-03-11T13:21:30.000-05:00
This PR was merged into the 4.1-dev branch. Discussion ---------- Default deleteFileAfterSend() to true This should default to true when called since there is only one option. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | N/A | Fixed tickets | N/A | License | MIT | Doc PR |  Commits ------- 1de6f73 Default deleteFileAfterSend() to true
diff --git a/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php b/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php
@@ -350,7 +350,7 @@ public static function trustXSendfileTypeHeader()
      *
      * @return $this
      */
-    public function deleteFileAfterSend($shouldDelete)
+    public function deleteFileAfterSend($shouldDelete = true)
     {
         $this->deleteFileAfterSend = $shouldDelete;
 

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ public static function trustXSendfileTypeHeader()`
`350`	`350`	`*`
`351`	`351`	`* @return $this`
`352`	`352`	`*/`
`353`		`- public function deleteFileAfterSend($shouldDelete)`
	`353`	`+ public function deleteFileAfterSend($shouldDelete = true)`
`354`	`354`	`{`
`355`	`355`	`$this->deleteFileAfterSend = $shouldDelete;`
`356`	`356`