minor symfony#26485 [DomCrawler] Improve the sprintf() call in selectLink() (dunglas)

fabpot · fabpot · commit b486fdaffd37 · 2018-03-11T13:17:53.000-05:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [DomCrawler] Improve the sprintf() call in selectLink() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? |no  | BC breaks? | no  | Deprecations? |no  | Tests pass? | yes  | Fixed tickets | n/a  | License | MIT | Doc PR | n/a Code cleanup and minor performance improvement. Commits ------- e2ab1a4 [DomCrawler] Improve the sprintf() call in selectLink()
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -710,10 +710,9 @@ public function filter($selector)
      */
     public function selectLink($value)
     {
-        $xpath = sprintf('descendant-or-self::a[contains(concat(\' \', normalize-space(string(.)), \' \'), %s) ', static::xpathLiteral(' '.$value.' ')).
-                            sprintf('or ./img[contains(concat(\' \', normalize-space(string(@alt)), \' \'), %s)]]', static::xpathLiteral(' '.$value.' '));
-
-        return $this->filterRelativeXPath($xpath);
+        return $this->filterRelativeXPath(
+            sprintf('descendant-or-self::a[contains(concat(\' \', normalize-space(string(.)), \' \'), %1$s) or ./img[contains(concat(\' \', normalize-space(string(@alt)), \' \'), %1$s)]]', static::xpathLiteral(' '.$value.' '))
+        );
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -710,10 +710,9 @@ public function filter($selector)`
`710`	`710`	`*/`
`711`	`711`	`public function selectLink($value)`
`712`	`712`	`{`
`713`		`- $xpath = sprintf('descendant-or-self::a[contains(concat(\' \', normalize-space(string(.)), \' \'), %s) ', static::xpathLiteral(' '.$value.' ')).`
`714`		`- sprintf('or ./img[contains(concat(\' \', normalize-space(string(@alt)), \' \'), %s)]]', static::xpathLiteral(' '.$value.' '));`
`715`		`-`
`716`		`- return $this->filterRelativeXPath($xpath);`
	`713`	`+ return $this->filterRelativeXPath(`
	`714`	`+ sprintf('descendant-or-self::a[contains(concat(\' \', normalize-space(string(.)), \' \'), %1$s) or ./img[contains(concat(\' \', normalize-space(string(@alt)), \' \'), %1$s)]]', static::xpathLiteral(' '.$value.' '))`
	`715`	`+ );`
`717`	`716`	`}`
`718`	`717`
`719`	`718`	`/**`