8000 config: Add test for Windows local paths. by filipnavara · Pull Request #977 · src-d/go-git · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

config: Add test for Windows local paths. #977

Merged
merged 1 commit into from
Oct 9, 2018
Merged

config: Add test for Windows local paths. #977

merged 1 commit into from
Oct 9, 2018

Conversation

filipnavara
Copy link
Contributor
  • Make sure that go-git is able to read unquoted local Windows path with escaped characters (as written by cgit).
  • Add test for writing it and round-tripping it, where both cases use quoted string, which is still accepted by cgit.

Issue #681

@filipnavara
Add test for Windows local paths.
c2ba07b 
Signed-off-by: Filip Navara <navara@emclient.com>
@filipnavara
Copy link
Contributor Author

I don't think the code coverage metric is calculated correctly if it decreased with added test coverage, or am I missing something?

@mcuadros mcuadros changed the title Config: Add test for Windows local paths. config: Add test for Windows local paths. Oct 9, 2018
@mcuadros
Copy link
Contributor
mcuadros commented Oct 9, 2018

@filipnavara don't worry, this small changes in coverages are irrelevant.

@mcuadros mcuadros merged commit 299f583 into src-d:master Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@filipnavara @mcuadros
0