8000 fix wildcard handling in RefSpec matching by novas0x2a · Pull Request #1160 · src-d/go-git · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

fix wildcard handling in RefSpec matching #1160

Merged
merged 1 commit into from
Jun 17, 2019
Merged

fix wildcard handling in RefSpec matching #1160

merged 1 commit into from
Jun 17, 2019

Conversation

novas0x2a
Copy link
Contributor
  1. The guard logic here was inverted, resulting in an always-false
    branch, which meant that the suffix after the wildcard was
    incorrectly ignored.
  2. Wildcards were treated as 1-or-more matches, but git treats them as
    0-or-more. This change aligns go-git with git, but represents a bit
    of a breaking change for go-git.

@novas0x2a
fix wildcard handling in RefSpec matching
af3226f 
1) The guard logic here was inverted, resulting in an always-false
   branch, which meant that the suffix after the wildcard was
   incorrectly ignored.
2) Wildcards were treated as 1-or-more matches, but git treats them as
   0-or-more. This change aligns go-git with git, but represents a bit
   of a breaking change for go-git.

Signed-off-by: Mike Lundy <mike@fluffypenguin.org>
@mcuadros mcuadros requested a review from jfontan June 6, 2019 13:02
@jfontan
Copy link
Contributor
jfontan commented Jun 10, 2019

I believe that windows tests are failing because a network problem. @mcuadros can you restart the test?

@mcuadros mcuadros merged commit a35ce6e into src-d:master Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jfontan jfontan jfontan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@novas0x2a @jfontan @mcuadros
0