This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: format/commitgraph, add APIs for reading and writing commit-graph files #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcuadros
reviewed
Apr 22, 2019
mcuadros
reviewed
Apr 22, 2019
c315339 to
c95d1f6
Compare
|
How can I make the CI pick up more recent go-git-fixtures? I'm not sure whether go.mod is still used since newer Go ignores it by default and it was not updated for ages in go-git repository. The actual coverage is 81.7% of statements, above the go-git average. Only error paths are not fully tested. |
c95d1f6 to
ab5b89c
Compare
…-graph files Signed-off-by: Filip Navara <filip.navara@gmail.com>
Signed-off-by: Filip Navara <filip.navara@gmail.com>
Signed-off-by: Filip Navara <filip.navara@gmail.com>
Signed-off-by: Filip Navara <filip.navara@gmail.com>
…coded file binary identical Signed-off-by: Filip Navara <filip.navara@gmail.com>
|
Thanks, I rebased it and now it will hopefully pick up the new fixtures on CI. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #965. This implements the low-level API for reading and writing the commit-graph files. Test cases are submitted in src-d/go-git-fixtures#16.
At the moment it doesn't allow adding custom chunks to the commit-graph file or reading them. The specification allows it and it should probably be supported since I used it for experiments before. However, Git itself doesn't write any non-standard chunks as of version 2.21.