8000 plumbing: ssh, Fix flaky test TestAdvertisedReferencesNotExists. Fixes #969 by mccurdyc · Pull Request #1013 · src-d/go-git · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

plumbing: ssh, Fix flaky test TestAdvertisedReferencesNotExists. Fixes #969 #1013

Merged
merged 2 commits into from
Nov 5, 2018
Merged

plumbing: ssh, Fix flaky test TestAdvertisedReferencesNotExists. Fixes #969 #1013

merged 2 commits into from
Nov 5, 2018

Conversation

mccurdyc
Copy link
Contributor
@mccurdyc mccurdyc commented Nov 1, 2018

Proposed Changes

Testing Methodology

  • I wrote a script
#!/usr/bin/env bash
for i in {1..5000}
do
  echo $i

  go test -v &>> out.txt

  if grep -q 'FAIL' out.txt
  then
    break
  fi
done

Previously, using this script and running 4 instances would cause the test to fail after about 50 iterations (i.e., the race condition would occur). It has run 850 iterations across all four instances without a failing test case.

Note: running 4 instances isn't necessary, but it does constrain resources and probably helps trigger the race condition

Relevant/Related Links

@mccurdyc mccurdyc mentioned this pull request Nov 1, 2018
Closed
@smola smola requested a review from mcuadros November 5, 2018 08:04
@mcuadros mcuadros merged commit 91e601d into src-d:master Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mcuadros mcuadros Awaiting requested review from mcuadros

1 more reviewer

@smola smola smola approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test TestAdvertisedReferencesNotExists

3 participants

@mccurdyc @smola @mcuadros
0