E527 use Helm values files by meyskens · Pull Request #250 · src-d/code-annotation · GitHub
[go: up one dir, main page]
Skip to content

use Helm values files #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meyskens merged 1 commit into from
Oct 17, 2018
Merged

use Helm values files #250

meyskens merged 1 commit into from
Oct 17, 2018

Conversation

@meyskens
Copy link
Contributor
@meyskens meyskens commented Oct 17, 2018

Signed-off-by: Maartje Eyskens maartje@eyskens.me
Is like #245 but using values files since drone-helm escapes quotes incorrect.

@meyskens meyskens requested a review from rporres October 17, 2018 08:34
@meyskens meyskens changed the title Uae Helm values files use Helm values files Oct 17, 2018
rporres
rporres approved these changes Oct 17, 2018
View reviewed changes
Copy link
@rporres rporres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once merge conflicts are solved, LGTM :)

@rporres rporres requested a review from carlosms October 17, 2018 09:41
carlosms
carlosms approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor
@carlosms carlosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@meyskens
Use Helm values files and add Nodeselector
e2845f2 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens meyskens merged commit e17d6b6 into master Oct 17, 2018
@meyskens meyskens deleted the helm-values-file branch October 17, 2018 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@carlosms carlosms carlosms approved these changes

@rporres rporres rporres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meyskens @carlosms @rporres
0