Request features from Review section with one call #233
Conversation
2e4b936 to
3445eb0
Compare
|
I didn't get why we need to change it to 1 call now. I would better extract fix for #229 in a separate commit and wait with other changes as api isn't ready yet. on another hand changes are small, so if you want to merge it, it's okay. |
|
@smacker all your doubts are properly explained in the PR description; for example:
|
3445eb0 to
87b5b79
Compare
There was a problem hiding this comment.
Although #233 (comment) has the point, the explanation about necessity of this work holds and even if it's a bit preliminary, it LGTM.
required by #198 and https://github.com/src-d/backlog/issues/1202
fixes #229
As defined by #198 (comment), the ML Feature Extractor API will take a couple of UAST, and it will return a bunch of features per each UAST, and a
scoreas a pair-featureThis PR prepares the frontend to do one call per FilePair being reviewed to obtain the features of each file, and the score itself.
This PR prepares the backend to answer following the expected schema.
No UI changes were done.
It was also added a
3445eb0 commit to fix #229 because otherwise the FilePairs beyond the first one cannot be reviewed.
Pending work
To be done once the ML Feature Extractor API is ready, but that does not block this PR:
model.Featuresmust be removed,featuresdb table must be removed → runningfeatures-drop-tablemigration from DB Migrations #221