8000 Replace '/' char from version by dpordomingo · Pull Request #230 · src-d/code-annotation · GitHub 8000
[go: up one dir, main page]
Skip to content

Replace '/' char from version #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpordomingo merged 2 commits into from
Mar 27, 2018
Merged

Replace '/' char from version #230

dpordomingo merged 2 commits into from
Mar 27, 2018

Conversation

@dpordomingo
Copy link
Contributor
dpordomingo commented Mar 26, 2018 •
edited
Loading

blocks #231

when a release branch is tested in Travis, the / char causes a conflict

> tar -cvzf $(PROJECT)_$(TAR_VERSION)_$${os}_$${arch}.tar.gz $(PROJECT)_$${os}_$${arch}/;
tar (child): code-annotation_release/v0.0.8_linux_amd64.tar.gz: Cannot open: No such file or directory

@dpordomingo dpordomingo requested review from carlosms and smacker March 26, 2018 09:32
@dpordomingo dpordomingo mentioned this pull request Mar 26, 2018
Merged
@dpordomingo dpordomingo self-assigned this Mar 26, 2018
@dpordomingo dpordomingo merged commit 65095a2 into src-d:ci Mar 27, 2018
@dpordomingo dpordomingo deleted the ci branch March 27, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smacker smacker Awaiting requested review from smacker

1 more reviewer

@carlosms carlosms carlosms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dpordomingo dpordomingo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpordomingo @carlosms
0