8000 Push release image by dpordomingo · Pull Request #183 · src-d/code-annotation · GitHub
[go: up one dir, main page]
Skip to content

Push release image #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpordomingo merged 1 commit into from
Mar 1, 2018
Merged

Push release image #183

dpordomingo merged 1 commit into from
Mar 1, 2018

Conversation

@dpordomingo
Copy link
Contributor
@dpordomingo dpordomingo commented Feb 28, 2018

fix #159

  • push release docker images
    • using the tag name,
    • latest image tag pointing to the just released tag
  • reuse in deploy and release events the common stages:
    • app building
    • docker image building and pushing

@dpordomingo dpordomingo requested review from bzz and rporres February 28, 2018 20:40
@dpordomingo dpordomingo mentioned this pull request Feb 28, 2018
Closed
2 tasks
@dpordomingo
Copy link
Contributor Author
dpordomingo commented Feb 28, 2018

@rporres I'd appreciate if you take a look to this PR :D

rporres
rporres approved these changes Mar 1, 2018
View reviewed changes
Copy link
@rporres rporres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, removes duplication

Apparently REACT_APP_SERVER_URL=//code-annotation-staging.srcd.run this is not needed anymore but I cannot comment on that 😅

@dpordomingo
Copy link
Contributor Author
dpordomingo commented Mar 1, 2018

@carlosms @smacker might want to take a look...

@dpordomingo dpordomingo merged commit 886da40 into src-d:master Mar 1, 2018
@dpordomingo dpordomingo deleted the release-artifacts branch March 2, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bzz bzz Awaiting requested review from bzz

2 more reviewers

@carlosms carlosms carlosms approved these changes

@rporres rporres rporres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Release process: publish more artefacts

3 participants

@dpordomingo @carlosms @rporres
0