8000 Add export button to top navbar by smacker · Pull Request #178 · src-d/code-annotation · GitHub
[go: up one dir, main page]
Skip to content

Add export button to top navbar #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smacker merged 1 commit into from
Feb 28, 2018
Merged

Add export button to top navbar #178

smacker merged 1 commit into from
Feb 28, 2018

Conversation

@smacker
Copy link
Contributor
@smacker smacker commented Feb 28, 2018

screen shot 2018-02-28 at 12 57 55

@smacker
Add export button to top navbar
efd6b59 
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
@smacker smacker requested a review from bzz February 28, 2018 11:58
@ricardobaeta
Copy link
Contributor
ricardobaeta commented Feb 28, 2018

@smacker Looks solid. I would just remove border-radius & shadow from the element, but it's not mandatory for now.

@bzz bzz requested a review from carlosms February 28, 2018 12:33
bzz
bzz approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor
@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

and 👍 for nice refactoring.

dpordomingo
dpordomingo approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor
@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
many thanks for this new shortcut !!
If it's easy for you to do it, please address @ricardobaeta suggestion, and if it's not let's merge now and add his suggestion to our UI todo list
(it would be nice to have a list of UI things to improve; I'm not sure if we already have it)

@smacker
Copy link
Contributor Author
smacker commented Feb 28, 2018

This PR adding one more item in menu. It doesn't change UI. Issue for ui: #179

@smacker smacker merged commit 9239a90 into src-d:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosms carlosms Awaiting requested review from carlosms

2 more reviewers

@dpordomingo dpordomingo dpordomingo approved these changes

@bzz bzz bzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smacker @ricardobaeta @dpordomingo @bzz
0