Merged
Conversation
lickel
commented
Oct 12, 2022
| isa = PBXNativeTarget; | ||
| buildConfigurationList = 471C508022C6D0DC007F73E9 /* Build configuration list for PBXNativeTarget "FetchRequests-iOS" */; | ||
| buildPhases = ( | ||
| 4736ABDC22CC3A1500253EB6 /* SwiftLint */, |
Collaborator
Author
There was a problem hiding this comment.
Removed for simplicity's sake (validate already does this)
AdamPro13
approved these changes
Oct 12, 2022
lickel
added a commit
that referenced
this pull request
Oct 12, 2022
* Generics * Remove some wheres * More generics * Collection generics * Interator.Element * Minor consistency * macOS compiles
lickel
added a commit
that referenced
this pull request
Oct 12, 2022
* Use Protocol Generics * Remove a bunch of where clauses * Remove `Iterator.Element`s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change protocols to be generic
Why
Simplify call sites / readability
How
This adds "primary" associated types for protocols where appropriate.
It then removes where clauses that can be defined via generic signatures.