E528 Ltree contains op by griffio · Pull Request #5880 · sqldelight/sqldelight · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@griffio
Copy link
Collaborator
@griffio griffio commented Aug 10, 2025

Example branch for basic LTREE support contains operator - see #5875

https://www.postgresql.org/docs/current/ltree.html

LTREE is a trusted PostgreSql extension and still requires CREATE EXTENSION Ltree

Shows type mapping of LTREE type and Integration test

🔕 Not for merging


  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

@yesitskev
Copy link

Hi @griffio, is there anything I can do to assist on this work item?

@griffio
Copy link
Collaborator Author
griffio commented Sep 22, 2025

Hi @griffio, is there anything I can do to assist on this work item?

This PR was to show a more complete implementation, the parts necessary to add this LTREE type and really any new type.
Grammar, Mixins, Type resolver, Type mapping and Integration tests are needed.

Ordinarily, adding a new type is not much of a problem, LTREE shares a few operators with existing types and this makes it more tricky to fit it in.

It makes sense to me that LTREE is part of the built in PostgreSql grammar as LTREE is a trusted extension CREATE EXTENSION ltree is still needed - creating a Dialect module would be difficult anyway due to the operators being shared by other types.

It would be good if you could land your existing PR and take this example that is mostly complete, replacing the code in your existing #5875. Also helps that I can approve another person's PR and get it merged, but not my own.

I can help with any questions or look into issues.

I will rebase this PR first as it has some conflicts with recent changes - then you can take it

@yesitskev I reapplied the changes to make it easier to see. You can make your original PR branch contain the same changes. You can see if it aligns with the features you need for LTREE or more work is needed with operators.

Add LTREE type

Add LTREE operators
Map LTREE type to driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0