8000 Revert "fix: Use derived ArrayDims instead of deprecated attndims" by kyleconroy · Pull Request #3033 · sqlc-dev/sqlc · GitHub
[go: up one dir, main page]
Skip to content

Revert "fix: Use derived ArrayDims instead of deprecated attndims" #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Revert "fix: Use derived ArrayDims instead of deprecated attndims" #3033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "fix: Use derived ArrayDims instead of deprecated attndims (#3032 
)"

This reverts commit 564f67d.
  • Loading branch information
@kyleconroy
kyleconroy authored Dec 4, 2023
commit b90132e5fc36a68752443e2e325370ceac260a07
5 changes: 3 additions & 2 deletions internal/engine/postgresql/analyzer/analyze.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ func (a *Analyzer) Analyze(ctx context.Context, n ast.Node, query string, migrat
if err != nil {
return nil, err
}
dt, isArray, dims := parseType(col.DataType)
// TODO: Why are these dims different?
dt, isArray, _ := parseType(col.DataType)
notNull := col.NotNull
name := field.Name
result.Columns = append(result.Columns, &core.Column{
Expand All @@ -262,7 +263,7 @@ func (a *Analyzer) Analyze(ctx context.Context, n ast.Node, query string, migrat
DataType: dt,
NotNull: notNull,
IsArray: isArray,
ArrayDims: int32(dims),
ArrayDims: int32(col.ArrayDims),
Table: &core.Identifier{
Schema: tbl.SchemaName,
Name: tbl.TableName,
Expand Down
0