10000 Fix typo in JavaDoc of setResponse method in MockClientHttpRequest by Dongnyoung · Pull Request #34856 · spring-projects/spring-framework · GitHub
[go: up one dir, main page]

Skip to content

Fix typo in JavaDoc of setResponse method in MockClientHttpRequest #34856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Dongnyoung
Copy link
Contributor

Hello,

This pull request fixes a grammatical error in the JavaDoc for the setResponse method in MockClientHttpRequest.

File: spring-test/src/main/java/org/springframework/mock/http/client/MockClientHttpRequest.java
Line: 107

Change:

  • Original: "the this request"
  • Changed to: "this request"

This update improves the clarity and professionalism of the documentation.

Thank you.

…ttpRequest

This pull request fixes a grammatical mistake in the JavaDoc of the setResponse method in MockClientHttpRequest.

- Original: "the this request"
- Changed to: "this request"

This change improves the clarity and quality of the documentation.

Signed-off-by: DongNyoung Lee <121621378+Dongnyoung@users.noreply.github.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 6, 2025
Copy link
Contributor
@DhruvTheDev1 DhruvTheDev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds clearer!

@rstoyanchev rstoyanchev changed the title Fix grammatical error in JavaDoc of setResponse method in MockClientHttpRequest. Fix typo in JavaDoc of setResponse method in MockClientHttpRequest Jun 3, 2025
@rstoyanchev rstoyanchev added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 3, 2025
@rstoyanchev rstoyanchev self-assigned this Jun 3, 2025
@rstoyanchev rstoyanchev added this to the 6.2.8 milestone Jun 3, 2025
@Dongnyoung
Copy link
Contributor Author

Thanks for addressing the issue!
Glad to see the fix has been applied — even though this PR was closed, I'm happy the improvement made it into the codebase.
Looking forward to contributing again! ☺️

@rstoyanchev
Copy link
Contributor
rstoyanchev commented Jun 4, 2025

Your commit is there, see 31903a9 in the event history, but it's applied to 6.2.x first because the target milestone is 6.2.8, and then forward merged into main.

@Dongnyoung
Copy link
Contributor Author

Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
491B
Development

Successfully merging this pull request may close these issues.

4 participants
0