8000 deps: loosen `pglast` constraint for python 3.11 support by branchvincent · Pull Request #814 · splitgraph/sgr · GitHub
[go: up one dir, main page]
Skip to content

deps: loosen pglast constraint for python 3.11 support #814

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

deps: loosen pglast constraint for python 3.11 support #814

merged 1 commit into from
Oct 10, 2023

Conversation

branchvincent
Copy link
Contributor

This adds support for python 3.11 by loosening the pglast constraint, which fails to build due to a C header longintrepr.h being moved (see python/cpython#79315). To reproduce:

$ poetry env use python3.11
$ poetry install
# ...
clang -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -I/opt/homebrew/include -I/opt/homebrew/include -I/private/var/folders/1r/p5nhsx151fd7j63p9r1zz4kw0000gn/T/pip-req-build-58dwok55/libpg_query -I/private/var/folders/1r/p5nhsx151fd7j63p9r1zz4kw0000gn/T/pip-req-build-58dwok55/libpg_query/src/postgres/include -I/private/var/folders/1r/p5nhsx151fd7j63p9r1zz4kw0000gn/T/pip-req-build-58dwok55/libpg_query/vendor -I/private/var/folders/1r/p5nhsx151fd7j63p9r1zz4kw0000gn/T/tmp.qP2MtS8D/sgr/.venv/include -I/opt/homebrew/opt/python@3.11/Frameworks/Python.framework/Versions/3.11/include/python3.11 -c pglast/parser.c -o build/temp.macosx-13-arm64-cpython-311/pglast/parser.o
        pglast/parser.c:282:12: fatal error: 'longintrepr.h' file not found
          #include "longintrepr.h"
                   ^~~~~~~~~~~~~~~
        1 error generated.
        error: command '/usr/bin/clang' failed with exit code 1
        [end of output]
    
    note: This error originates from a subprocess, and is likely not a problem with pip.
    ERROR: Failed building wheel for pglast
  Failed to build pglast

Note that 3.15 was the first pglast version that officially supported 3.11, but I've left the lower bound untouched (let me know if you'd like something different)

@branchvincent branchvincent mentioned this pull request Jul 6, 2023
Merged
@alex alex mentioned this pull request Jul 26, 2023
Merged
@chenrui333
Copy link

cc @neumark

@chenrui333 chenrui333 mentioned this pull request Oct 10, 2023
Merged
@mildbyte
Copy link
Contributor

Thanks! We'll merge this to trigger the build.

@mildbyte mildbyte merged commit 0c6523b into splitgraph:master Oct 10, 2023
@branchvincent branchvincent deleted the pglast branch October 11, 2023 16:11
@chenrui333
Copy link

@mildbyte thanks for the merge, any chance to cut a new release? 🙏

@chenrui333 chenrui333 mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@branchvincent @chenrui333 @mildbyte
0