[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): Add support for ECS deployment circuit breaker #10076

Merged
merged 2 commits into from
Jan 17, 2024
Merged

feat(ecs): Add support for ECS deployment circuit breaker #10076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33f824f
feat(ecs): Add support for ECS deployment circuit breaker
jgrumboe Jan 5, 2024
f564345
chore(ecs): rearrange checkbox for deployment circuit breaker to bett…
jgrumboe Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ecs/src/ecs.help.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const helpContents: { [key: string]: string } = {
'ecs.placementStrategy':
'<p>The strategy the container scheduler will be using. See <a href="http://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-placement-strategies.html" target="_blank">AWS documentation</a> for more details. </p><p>You should at least balance across availability zones</p><p>Custom placement strategies have not been implemented yet.</p>',
'ecs.platformVersion': '<p>Defaults to the latest platform version.</p>',
'ecs.enableDeploymentCircuitBreaker': '<p>Enable circuit breaker for the ECS service.</p>',
'ecs.capacity.copySourceScalingPoliciesAndActions':
'<p>Copy Application Autoscaling policies and their associated alarms from the previous ECS service.</p>',
'ecs.launchtype': '<p>Launch service tasks on your own EC2 instances or on Fargate.</p>',
Expand Down
1 change: 1 addition & 0 deletions packages/ecs/src/serverGroup/configure/serverGroupCommandBuilder.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ angular
copySourceScalingPoliciesAndActions: true,
preferSourceCapacity: true,
useSourceCapacity: true,
enableDeploymentCircuitBreaker: false,
viewState: {
useAllImageSelection: false,
useSimpleCapacity: true,
Expand Down
10 changes: 10 additions & 0 deletions ...ges/ecs/src/serverGroup/configure/wizard/advancedSettings/advancedSettings.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,16 @@
</div>
</div>

<div class="form-group">
<div class="col-md-5 sm-label-right">
Enable Deployment Circuit Breaker
<help-field key="ecs.enableDeploymentCircuitBreaker"></help-field>
</div>
<div class="col-md-3">
<input type="checkbox" ng-model="$ctrl.command.enableDeploymentCircuitBreaker" />
</div>
</div>

<div class="form-group">
<div class="col-md-5 sm-label-right">
<b>Placement Strategy</b> <help-field key="ecs.placementStrategy"></help-field>
Expand Down