Make it possible to mock the current time in spiffetls dialer #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So you can do, say,
spiffetls.DialWithMode(
ctx, network, addr, mode,
spiffetls.WithDialTLSOptions(tlsconfig.WithTime(mocked))
)
This is useful in tests and is already supported by the underlying
crypto/x509 library and even by the x509svid package right here but just
wasn't plumbed through to the dialer.
azdagron
reviewed
Sep 13, 2025
|
|
||
| // WithTime sets the time used when verifying validity periods on X509 SVIDs. | ||
| // If not used, the current time will be used. | ||
| func WithTime(now time.Time) Option { |
There was a problem hiding this comment.
To be consistent in the way we've passed through options in other packages, I'd recommend that we instead add a function func WithVerifyOptions(opts ...x509svid.VerifyOption) Option instead of replicating the individual options here.
|
Also, we'll need DCO signoff an all commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So you can do, say,
spiffetls.DialWithMode(
ctx, network, addr, mode,
spiffetls.WithDialTLSOptions(tlsconfig.WithTime(mocked))
)
This is useful in tests and is already supported by the underlying crypto/x509 library and even by the x509svid package right here but just wasn't plumbed through to the dialer.