ENH Add alt attribute for thumbnails #668
Conversation
|
@larsoner I don't understand the cause of the test failures. I seems that but there all 3 output variables (intro, title, cost) are present. |
|
beware the multiple |
There was a problem hiding this comment.
Also do you think the test is adequate?
I find it handy to add a line to test_full.py to check the HTML. Here you can assert that there is alt="..." in the index.html of a gallery containing the title of an example -- it shouldn't be there on master but should be there on this PR
sphinx_gallery/gen_rst.py
Outdated
| @@ -336,12 +336,13 @@ def generate_dir_rst(src_dir, target_dir, gallery_conf, seen_backrefs): | |||
| 'generating gallery for %s... ' % build_target_dir, | |||
| length=len(sorted_listdir)) | |||
| for fname in iterator: | |||
| intro, cost = generate_file_rst( | |||
| print('for {} generate file run'.format(fname)) | |||
There was a problem hiding this comment.
😂 oh no, my print statement debugging exposed!
Maybe but we can wait until someone has a problem :) |
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 97.78% 97.79% +0.01%
==========================================
Files 31 31
Lines 3247 3266 +19
==========================================
+ Hits 3175 3194 +19
Misses 72 72
Continue to review full report at Codecov.
|
|
@larsoner added a check in html and rst for index and backref thumbnail alt. Also added a html test to image alts. |
|
Thanks @lucyleeow |
|
cc @ogrisel see https://1473-25860190-gh.circle-artifacts.com/0/rtd_html/auto_examples/index.html for thumbnail alt example :) |
closes #664