[MRG] CSS: add a CSS class to links in code #145
Conversation
The goal is to enable downstream to style the doc-resolv links in code examples specially.
|
To make this functionality more discoverable, I've added a title to the link, that hints to what the link points to, and CSS code so that the title appears with no delay when the user hovers: |
|
this looks very nice |
|
Very nice indeed! @Titan-C I don't remember does readthedocs build on each PR or only on each commit into master? It would be nice to see the generated sphinx-gallery doc on PRs ... |
|
Merged thanks. |
|
Hmmm actually I should have tested this a bit more I get two popups for some reason (both locally and on readthedocs). Here is a snapshot:
|
|
Hmmm actually I should have tested this a bit more I get two popups for some
reason (both locally and on readthedocs).
OK. I'll fix this ASAP.
I actually really hate readthedocs because it makes it so hard to test
things without merging.
|
In this case I get this locally too though. In this case I'll blame myself for merging while blindly trusting someone ;-). |
|
Having said that it'd be great if we could use the readthedocs theme so that it looks the same locally and on readthedocs ... no idea whether it's difficult or not. |
|
We have two issues here:
|
Apparently that's not always the case. I've pushed a fix on |
Fixed double tooltip problem as mentioned in #145.
readthedocs only builds after is pushed into master and for every commit to which version tag is put. I'm also thinking in having the docs build in CircleCI as you do in nilearn/scikit-learn |
I do that manually from time to time. I can set it up as part of our configuration. It will of course require you have the readthedocs theme installed(is in conda and pip) |
|
I do that manually from time to time. I can set it up as part of our
configuration. It will of course require you have the readthedocs theme
installed(is in conda and pip)
Would it be possible to have it as a different make target? I actually
think that it's useful to build under different themes, to avoid having
choices that are too specific to a given theme.
|
The goal is to enable downstream to style the doc-resolv links in code examples specially.