MNT Change mark and fixture names for adding files #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
for more information, see https://pre-commit.ci
larsoner
reviewed
Aug 2, 2024
doc/configuration.rst
Outdated
| to treat warnings as errors, e.g., with a line like | ||
| ``warnings.filterwarnings("error")``. Note that this | ||
| to treat warnings as errors. Note that this |
There was a problem hiding this comment.
Please revert, this filterwarnings("error") is really the relevant hint that projects like matplotlib and mne would have likely noticed.
There was a problem hiding this comment.
Ah I did not understand what this filter was doing. Let me update the doc in a new PR and I'll revert here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1360 (comment)
conf_filefixture and mark were name the same which makes it confusing.