MAINT: Fix for Sphinx 7.2 #1176
Conversation
|
Hi! Does this patch also fix this error I am seeing downstream with Sphinx 7.2.2 and sphinx-gallery 0.13.0 ? Example log: https://readthedocs.org/projects/astropy/builds/21642243/ (from astropy/astropy#15185) |
|
Nope, but I can open a quick PR for you to test |
|
... actually it looks like that was fixed before this PR, so |
|
In that case, what is the timeline to release sphinx-gallery? |
|
None at the moment. In theory we should release given the breakages I guess! You can use for example |
|
@lucyleeow WDYT about cutting a release? |
|
I want to avoid pinning our infrastructure to unreleased sphinx-gallery if possible, so I can pin |
|
Just to report back that using the dev version of sphinx-gallery + sphinx 7.2.2 , I got a green RTD build, so I am looking forward to your release. Thanks! |
|
Thanks @larsoner ! I was wondering how the |
Sorry I don't think I will have time for that. I will fix my PRs though so they get in. |
|
From the looks of https://github.com/sphinx-gallery/sphinx-gallery/blob/master/.github/workflows/release.yml , anyone with maintainer access should be able to release? p.s. You don't need to upload/download artifact unless you are building architecture specific wheels, which I don't think you are. |
|
@larsoner I've done some labelling to make release easier for you. Thank you 🙏 |
|
I saw that on your PRs, much appreciated :) I'll look into releasing now, indeed with the |
… to version 0.14.0 v0.14.0 ------- **Implemented enhancements:** - MAINT Update backreferences docs and add tests `#1154 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1154>`__ (`lucyleeow <https://github.com/lucyleeow>`__) - Remove extra spaces in reported running time `#1147 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1147>`__ (`stefanv <https://github.com/stefanv>`__) **Fixed bugs:** - MAINT: Fix for Sphinx 7.2 `#1176 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1176>`__ (`larsoner <https://github.com/larsoner>`__) - updated mpl gui warning catcher to new error message `#1160 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1160>`__ (`story645 <https://github.com/story645>`__) - Ensure consistent encoding for md5sum generation `#1159 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1159>`__ (`sdhiscocks <https://github.com/sdhiscocks>`__) - Maint: Fix ``app.builder.outdir`` as Sphinx now using pathlib `#1155 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1155>`__ (`lucyleeow <https://github.com/lucyleeow>`__) - Make \_LoggingTee compatible with TextIO `#1151 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1151>`__ (`o-laurent <https://github.com/o-laurent>`__) (NEWS truncated at 15 lines)
Closes #1175