Remove default '%matplotlib inline' line #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GaelVaroquaux @ArturoAmorQ I thought this would make our downloadable notebooks no longer behave the same for end-users when they download and run code locally, but local testing suggests that the plot does still end up inline. So this is okay by me! |
|
... and as such I consider this a sort of bugfix |
|
but local testing suggests that the plot does still end up inline.
Yes, the ecosystem improved and things now work out much better (it's nice, isn't it).
|
|
Very nice, I meant to do that as the first follow-up to the Jupyterlite integration #977! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091.
My approach with the test was simply to remove the assertion, but I am sure there might be a better way to do it. Any feedback is welcomed.