Refactor some internal LaTeX code #9000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codeline wrapping in literal blocks (possibly hard-wrap in presence of unbreakable long strings) requires a measurement step. Spring 2021 LaTeX adds quite some overhead to each and every paragraph to insert hooks at begin and end of paragraphs. For technical reasons, our measurement (which uses a paragraph in a scratch box) could be broken by the "after para" hook. Work around that.
|
Thanks for rev B3FA iew, merging! |
jfbu
added a commit
to jfbu/sphinx
that referenced
this pull request
Mar 15, 2021
Reason is that mark-up such as this:
.. attribute:: state
state_machine
The state and state machine which controls the parsing. Used for
``nested_parse``.
generates two `\pysigline` each with `\phantomsection`. The latex code
to get good vertical spacing between label and its description, if label
``\parbox`` is multi-line, cause in this context the two (generally,
single-line) labels to be stacked vertically with no spacing.
This commit keeps the ``\parbox`` which fixes sphinx-doc#8980, but drops the
attempt to correct vertical distance to description, so as to not alter
the possibly more common use case of items with common description.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codeline wrapping in literal blocks (possibly hard-wrap in presence of
unbreakable long strings) requires a measurement step. Spring 2021 LaTeX
adds overhead to each and every paragraph to insert hooks at
begin and end of paragraphs. For technical reasons, our measurement
(which uses a paragraph in a scratch box) could be broken by the "after
para" hook. Work around that. Perhaps actual Spring 2021 LaTeX will
have some interface to not execute hook, but this should still work.
Feature or Bugfix