< 8000 bdi class="js-issue-title markdown-title">WIP: allow checking po files #11
Conversation
TODO: tests
|
python/python-docs-fr#1824 fixes most of these issues in |
I think so, as it's clearly not the main use of sphinx-lint. We'll just have to write a nice warning message like "Skipping po file: please install sphinx-lint[po] if you want for sphinx-lint to check them too", because it could happen that a po file is in the checked tree, I don't want sphinx-lint to |
There was a problem hiding this comment.
This seems a useful feature -- I was just looking into linting some of the CPython translations --, however I think it would be better to make it optional and hide it behind an explicit flag, e.g. --check-po-files.
If the flag is specified it could check if polib is installed and give an error if it isn't. If it's installed it can include .po files in the check.
Regarding the implementation I think it would be better if there was a bit less coupling, but that will likely make the PR more complex. Since there probably aren't many other file types we want to check, then I'd say the current implementation is ok -- we can always refactor later if we add more file types.
|
I'm a bit short on time right now. I hope to pick this up, but it might not be very soon. (But feel free to beat me to it.) |
|
I've "merged" your PR, with a slightly different approch as the code has evolved a lot since then. Thanks for the PR, the idea, and the initial implementation!! |
|
Thanks @JulienPalard! |
|
@jean-abou-samra I'm fixing those found in python-docs-fr and will open a PR to add sphinx-lint to the CI of python-docs-fr (and propose it to other translations). |
|
SGTM. |
TODO: tests
This finds almost 100 issues in python-docs-fr, mostly about usage of the default role.
Open question is whether polib should be an optional dependency.