8000 android: update app icon; use "adaptive icons" on API 26+ by SomberNight · Pull Request #7187 · spesmilo/electrum · GitHub
[go: up one dir, main page]
Skip to content

android: update app icon; use "adaptive icons" on API 26+ #7187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2021
Merged

android: update app icon; use "adaptive icons" on API 26+ #7187

merged 1 commit into from
Apr 8, 2021

Conversation

SomberNight
Copy link
Member

see https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive

p4a and buildozer had to be patched for this; I will try to upstream the patches, see:
kivy/python-for-android#2446
kivy/buildozer#1312

Here is how the launcher looks on two different phones (both API 26+, so using the adaptive icon):
launcher1
launcher2

@SomberNight SomberNight added this to the 4.1.2 milestone Apr 7, 2021
@ecdsa
Copy link
Member
ecdsa commented Apr 8, 2021

with this PR, the legacy icon gets used on my phone (android 10), and it is used "as is" (full rectangle)

@SomberNight
Copy link
Member Author

have you rebuilt the docker image + buildozer?

@ecdsa
Copy link
Member
ecdsa commented Apr 8, 2021

only buildozer; I did not see that the Docker image had changes :-)

@ecdsa
Copy link
Member
ecdsa commented Apr 8, 2021 •
edited
Loading

I guess it is working for me now, after rebuilding.
A couple of issues remain:

  • the new legacy icon looks worse than the one that was replaced (Electrum_512.png). why did you change it?
  • with the adaptive icons, my android crops part of the image (ellipses)
  • if I change the shape of icons on my system, it works for some of the installed apps, but not for Electrum (but that setting is called "icon pack", so I suspect it is not using the adaptiveness of adaptive icons)

@SomberNight
Copy link
Member Author

the new legacy icon looks worse than the one that was replaced (Electrum_512.png). why did you change it?

Mainly to make the adaptive/non-adaptive icons look similar; but I guess it's not important. Also, while I was testing this I could never be sure why it was working or not-working; so I replaced all icons with ones that have identical resolution to what the default project created by Android Studio has: 192x192 for legacy; 432x432 for adaptive (well actually Android Studio created them in 5 different resolutions... these being the largest).

with the adaptive icons, my android crops part of the image (ellipses)

Well, looking at the images I've uploaded in the opening comment I guess it's not surprising. The adaptive foreground needs even larger margins...

@SomberNight
Copy link
Member Author

with the adaptive icons, my android crops part of the image (ellipses)

Well, looking at the images I've uploaded in the opening comment I guess it's not surprising. The adaptive foreground needs even larger margins...

(from https://medium.com/google-design/designing-adaptive-icons-515af294c783)
see

I will make the margins larger.

@SomberNight SomberNight force-pushed the 202104_android_adaptiveicon branch from 750e8cd to 3d97987 Compare April 8, 2021 11:34
@ecdsa ecdsa merged commit 5ac130a into spesmilo:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OS-android🤖
Projects
None yet
Milestone
4.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@SomberNight @ecdsa
0