8000 feat(/api/unicode/names): add unicode codepoint to name service by sidvishnoi · Pull Request #424 · speced/respec-web-services · GitHub
[go: up one dir, main page]

Skip to content

Conversation

sidvishnoi
Copy link
Member
@sidvishnoi sidvishnoi commented Jun 22, 2024

Part of speced/respec#4462

@sidvishnoi sidvishnoi requested a review from marcoscaceres July 7, 2024 15:47
@sidvishnoi sidvishnoi marked this pull request as ready for review July 7, 2024 15:55
options = { ...defaultOptions, ...options } as Options;
const hasUpdated = await updateInputSource();
if (!hasUpdated && !options.forceUpdate) {
console.log("Nothing to update");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log("Nothing to update");
console.log("Nothing to update from Unicode.");

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or something similar... just for a bit more context.

Copy link
Collaborator
@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0