8000 [issue-532] Add linter action by meretp · Pull Request #544 · spdx/tools-python · GitHub
[go: up one dir, main page]
Skip to content

[issue-532] Add linter action #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2023
Merged

[issue-532] Add linter action #544

merged 3 commits into from
Mar 30, 2023

Conversation

meretp
Copy link
Collaborator
@meretp meretp commented Mar 30, 2023

This PR adds a GitHub Action to check the code style with black, isort and flake8. The new GitHub Action is expected to fail as the current code doesn't comply with these linters. A second PR will follow to fix this.

meretp added 3 commits March 30, 2023 08:21
@meretp
[fix] adapt GitHub Action after merge to main
a50d72c 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-532] add GitHub Action to check the code style
6fe7129 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
delete outdated configuration files
b3f08f2 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp meretp force-pushed the add-linter-action branch from 19d25cc to b3f08f2 Compare March 30, 2023 06:49
@meretp meretp self-assigned this Mar 30, 2023
@meretp meretp linked an issue Mar 30, 2023 that may be closed by this pull request
Automated PEP8 checking #532
Closed
armintaenzertng
armintaenzertng approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator
@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just tried it and it worked mostly except for very long strings. Is this something that has to be done manually?

@meretp
Copy link
Collaborator Author
meretp commented Mar 30, 2023

Unfortunately yes. With a quick research I found that there are some tools that could do this automatically but as this would probably need more work (setting up the tool and so on), I decided to do it manually. I would assume that this is a justifiable effort in the future.

@meretp meretp merged commit 487f7a9 into spdx:main Mar 30, 2023
@meretp meretp mentioned this pull request Mar 30, 2023
Merged
@armintaenzertng
Copy link
Collaborator

A fix of this is part of #546

@meretp meretp deleted the add-linter-action branch May 10, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armintaenzertng armintaenzertng armintaenzertng approved these changes

Assignees

@meretp meretp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated PEP8 checking
2 participants
@meretp @armintaenzertng
0