8000 Merged the refactoring branch into main by maxhbr · Pull Request #541 · spdx/tools-python · GitHub
[go: up one dir, main page]
Skip to content
8000

Merged the refactoring branch into main #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 363 commits into from
Mar 29, 2023
Merged

Merged the refactoring branch into main #541

merged 363 commits into from
Mar 29, 2023

Conversation

maxhbr
Copy link
Member
@maxhbr maxhbr commented Mar 29, 2023

This is not to be merged, but instead its HEAD 3f2619c is the relevant merge commit should directly be pushed to main.

@goneall : can you open the branch protection rules for a short window so that I can push or otherwise you can push it (if admins can ignore branch protection rules in this repo)?

nicoweidner and others added 30 commits January 3, 2023 10:25
@nicoweidner @armintaenzertng
[issue-359] Add validation to json writer, with the possibility of di…
d9edf4d 
…sabling it

Signed-off-by: Nicolaus Weidner <nicolaus.weidner@tngtech.com>
@nicoweidner @armintaenzertng
[issue-359] Add docstrings to some core files
ce29322 
Signed-off-by: Nicolaus Weidner <nicolaus.weidner@tngtech.com>
@nicoweidner @armintaenzertng
[issue-359] Extract common method to get all spdx element ids inside …
d77ec7a 
…a document

Signed-off-by: Nicolaus Weidner <nicolaus.weidner@tngtech.com>
@nicoweidner @armintaenzertng
[issue-359] Use extracted relationship filtering methods in document_…
5eb63e4 
…validator.py

Signed-off-by: Nicolaus Weidner <nicolaus.weidner@tngtech.com>
@armintaenzertng
[issue-388] implement CLI parser/validator
b964a17 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-388] introduce format enum and write_anything.py
c68fbc8 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-388] implement CLI convertor and rewrite docstrings
8f08e0c 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-388] remove obsolete tests
ca9aee5 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-388] include json writer
17fedb6 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-388] rework the CLI user flow
aee3e10 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-388] merge parser and convertor into a single tool and update …
a9b6525 
…the README

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-397] change fixtures to use valid defaults
f4c48f7 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-397] replace valid_defaults.py usages with fixtures.py
35ed3d8 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-403] change spdx version handling during validation
da5705e 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-403] restructure spdx version validation
e455066 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-406] rename json parser package to jsonlikedict
b930fac 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-406] extract json parser and restructure test order
6696597 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-406] add xml writer
b59da62 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-406] add xml parser
5e65349 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-406] add yaml writer
483f459 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-406] add yaml parser
ea747c8 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-406] fix xml specific problems, update parse/write_anything
3765409 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-406] fix copyright texts
664a646 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-267] add GitHub Actions workflow and remove CircleCI
7dc8024 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-267] add pull_request to CI triggers
1245e22 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-267] remove on push trigger
a25a384 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
fix hasExtractedLicensingInfos
9b4dd28 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
fix filesAnalyzed parsing
9034f3d 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@meretp
[issue-415] introduce src-layout to fix cli
533328b 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-415] run cli tool in GitHub action
7f3cd5e 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp and others added 27 commits March 9, 2023 12:12
@meretp
squashed review commits
e5af2eb 
[review] fix parsing of external document ref
[review] use only one dictionary
[review] return if multiple values for snippet range found

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-228] make type hints in code readable for downstream packages
752e964 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[fix] move "py.typed" to package root directory
0aff1b5 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[fix] write LicenseListVersion only when provided
5d3cab0 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-394] add tests for creation info writer
2624690 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[refactor] use f-strings, double quotes and more descriptive variable…
08b447d 
… names

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@armintaenzertng
[issue-518] rename file_type to file_types
34d0045 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@meretp
[issue-503] validate license_expressions only as a List of LicenseExp…
4a0675f 
…ression, SpdxNone or SpdxNoAssertion

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-503] fix: correct type for LicenseInfoInSnippet in Snippet
66a3355 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-503] fix: correct type for LicenseInfoFromFiles in Package
dcfc471 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-503] fix: correct type for LicenseInfoInFile in File
44250c1 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-503] fix: delete helper method as we don't need to distinguish…
8d2f497 
… cases for LicenseInfoFromFiles, LicenseInfoInFile and LicenseInfoInSnippet

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@armintaenzertng
fixed the version of typeguard as 3.0.0 introduces breaking changes
91b05dc 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@HarshvMahawar @armintaenzertng
Added convenience function to extract SPDX elements by their Id
ea92a1c 
Signed-off-by: HarshvMahawar <hv062727@gmail.com>
@meretp
[issue-402] add validation option to tag-value writer
9f998b9 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[issue-402] drop spdx version as input argument as it is automaticall…
d1c01f8 
…y inferred from the creation_info

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[fix] add python 3.11 to GitHub Action
1d84bcb 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@meretp
[fix] also run GitHub Action after merge
2261824 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@goneall @armintaenzertng
Create dependabot.yml
ba2c580 
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@armintaenzertng
update changelog for v0.7.1
b132d32 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@meretp @armintaenzertng
[issue-468] add a step to fork the repository
de1e86e 
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
delete unused test data
3019702 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
delete unused license lists and corresponding files
9158ecb 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
change DATE to ISO8601_DATE, don't inherit from object
69e938a 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
update README for when the refactor branch is merged to main
563196d 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng
[issue-487] add tests for the document_utils module
63dc18a 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@maxhbr
Merge branch 'refactor-python-tools'
3f2619c 
This merges the long awaited refactoring. The "old" 0.7.1 release is
still on its own branch and can receive bugfixes there.

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
@maxhbr maxhbr requested a review from goneall March 29, 2023 13:50
goneall
goneall approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member
@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review all 365 files, but the structure looks good and I agree we should move the refactored branch into main.
2364

@maxhbr maxhbr merged commit 3f2619c into main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maxhbr @goneall @nicoweidner @armintaenzertng @meretp @HarshvMahawar
0