8000 Clipping plane management by nashmit · Pull Request #1000 · spatial-model-editor/spatial-model-editor · GitHub
[go: up one dir, main page]

Skip to content

Clipping plane management #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Clipping plane management #1000

wants to merge 8 commits into from

Conversation

nashmit
Copy link
Contributor
@nashmit nashmit commented Aug 29, 2024

Add clipping plane GUI interaction.

@nashmit nashmit self-assigned this Aug 29, 2024
@nashmit nashmit added the 3d 3d model support label Aug 29, 2024
@nashmit nashmit linked an issue Aug 29, 2024 that may be closed by this pull request
3 tasks
Copy link
codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 77.16535% with 29 lines in your changes missing coverage. Please review.

Project coverage is 86.17%. Comparing base (4970eee) to head (92588ca).

Files with missing lines Patch % Lines
gui/widgets/qopenglmousetracker.cpp 73.87% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   90.13%   86.17%   -3.96%     
==========================================
  Files         132      135       +3     
  Lines       14358    14398      +40     
==========================================
- Hits        12941    12407     -534     
- Misses       1417     1991     +574     
Flag Coverage Δ
cli 19.16% <0.00%> (-0.03%) ⬇️
core 45.78% <0.00%> (-0.16%) ⬇️
gui 67.88% <77.16%> (-0.39%) ⬇️
mainwindow 38.19% <3.93%> (-0.11%) ⬇️
sme 28.17% <0.00%> (-3.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3d 3d model support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipping planes management in GUI.
1 participant
0