This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Upgrade cody web experimental package to 0.2.7#63863
Merged
vovakulikov merged 2 commits intomainfrom Jul 16, 2024
Merged
Conversation
camdencheek
reviewed
Jul 16, 2024
| chatID={chatID} | ||
| initialContext={contextInfo} | ||
| serverEndpoint={window.location.origin} | ||
| customHeaders={window.context.xhrHeaders} |
Member
There was a problem hiding this comment.
Ah! That's what those are for 😄
camdencheek
approved these changes
Jul 16, 2024
Collaborator
|
The backport to To backport this PR manually, you can either: Via the sg toolUse the sg backport -r 5.5.x -p 63863Via your terminalTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.5.x 5.5.x
# Navigate to the new working tree
cd .worktrees/backport-5.5.x
# Create a new branch
git switch --create backport-63863-to-5.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 290838344e95cf1c68a502c88759fd3f26b20544
# Push it to GitHub
git push --set-upstream origin backport-63863-to-5.5.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.5.xIf you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-63863-to-5.5.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.5.x
Once the pull request has been created, please ensure the following:
|
michaellzc
pushed a commit
that referenced
this pull request
Jul 18, 2024
S2 Cody Web is broken at the moment. New client-config handlers fail with 401 status because we don't send custom headers, this works for gql queries since they all are POST requests and the browser automatically sends an Origin header for them and this is enough for our auth middleware to check cookies, but with client-config which is rest it's not the case and we should send `X-Requested-Client: Sourcegraph` header to make our auth middleware to pass this query correctly Note that this problem doesn't exist in local builds since we proxy all requests and add `X-Requested-Client: Sourcegraph` in dev server. See Cody latest build PR for more details https://github.com/sourcegraph/cody/pull/4898 ## Test plan - CI is passing (cherry picked from commit 2908383)
craigfurman
pushed a commit
that referenced
this pull request
Jul 18, 2024
…) (#63901) backport https://github.com/sourcegraph/sourcegraph/pull/63863 S2 Cody Web is broken at the moment. New client-config handlers fail with 401 status because we don't send custom headers, this works for gql queries since they all are POST requests and the browser automatically sends an Origin header for them and this is enough for our auth middleware to check cookies, but with client-config which is rest it's not the case and we should send `X-Requested-Client: Sourcegraph` header to make our auth middleware to pass this query correctly Note that this problem doesn't exist in local builds since we proxy all requests and add `X-Requested-Client: Sourcegraph` in dev server. See Cody latest build PR for more details https://github.com/sourcegraph/cody/pull/4898 ## Test plan CI Co-authored-by: Vova Kulikov <vovakulikov@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S2 Cody Web is broken at the moment. New client-config handlers fail with 401 status because we don't send custom headers, this works for gql queries since they all are POST requests and the browser automatically sends an Origin header for them and this is enough for our auth middleware to check cookies, but with client-config which is rest it's not the case and we should send
X-Requested-Client: Sourcegraphheader to make our auth middleware to pass this query correctlyNote that this problem doesn't exist in local builds since we proxy all requests and add
X-Requested-Client: Sourcegraphin dev server.See Cody latest build PR for more details https://github.com/sourcegraph/cody/pull/4898
Test plan