fix: Normalize name and version correctly

sourcegraph · varungandhi-src · Sep 7, 2023 · Aug 23, 2023 · Sep 7, 2023 · Sep 7, 2023
commit f035b39eb5efb3318165161dd4f4629142b85302
diff --git a/packages/pyright-scip/src/ScipSymbol.ts b/packages/pyright-scip/src/ScipSymbol.ts
@@ -7,10 +7,21 @@ export class ScipSymbol extends TypescriptScipSymbol {
     }
 
     public static override package(name: string, version: string): TypescriptScipSymbol {
-        name = name.replace(/\./, '/');
-        name = name.trim();
+        name = normalizeNameOrVersion(name);
+        version = normalizeNameOrVersion(version);
 
         // @ts-ignore
         return new TypescriptScipSymbol(`scip-python python ${name} ${version} `);
     }
 }
+
+// See https://github.com/sourcegraph/scip/blob/main/scip.proto#L118-L121
+function normalizeNameOrVersion(s: string): string {
+    if (s === '') {
+        return '.';
+    }
+    if (s.indexOf(' ') === -1) {
+        return s;
+    }
+    return s.replace(/ /g, '  ');
+}