catch exceptions instead of letting them hard fail builds#55
Merged
Conversation
olafurpg
reviewed
Apr 18, 2023
| return super.analysisCompleted(project, module, bindingTrace, files) | ||
| } | ||
| super.analysisCompleted(project, module, bindingTrace, files) | ||
| } catch (e: Exception) { |
Contributor
There was a problem hiding this comment.
Does Kotlin have something similar to Scala's NonFatal handler?
You typically don't want to catch Exception since it swallows fatal exceptions like OOM or VM failures that should propagate.
Contributor
Author
There was a problem hiding this comment.
OOM and other *Error throwables arent a subclass of Exception, so they wouldnt be caught by this, theyre subclasses of Error. NonFatal in Scala deals with throwables, the supertype of error and exception
keynmol
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having issues with getting the exceptions logged (in any way, even directly with stderr), have asked in official slack about itHave implemented a workaround that also involves a change in scip-java, PR here: sourcegraph/scip-java#551Test plan
Added unit test and ran E2E via sbt-invoked
scip-java