output: refactor to use go.bobheadxi.dev/streamline under the hood #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a81f4c0 to
ebe62db
Compare
ebe62db to
a433255
Compare
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 79.12% 75.76% -3.36%
==========================================
Files 11 10 -1
Lines 388 326 -62
==========================================
- Hits 307 247 -60
+ Misses 66 65 -1
+ Partials 15 14 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change swaps out
run.Output's internals withgo.bobheadxi.dev/streamline. The interface is unchanged except for the addition ofWithPipelinethat allows compatibility withstreamline/pipeline, and all tests pass with some minor adjustments (such as correctly returningio.EOFon reads that reach the end of input).streamlineis a library I've been working on on the side to generalize some of the ideas ofrun.Outputfor arbitrary input. The code is simpler and easier to maintain (I wrote a lot of weird stuff into the initialrun.Outputimplementation), and I'll probably continue working on it to improve the performance and fix issues and whatnot :)